From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 04 08:58:25 2021 Received: (at 45403) by debbugs.gnu.org; 4 Jan 2021 13:58:25 +0000 Received: from localhost ([127.0.0.1]:58130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNM-0006gK-PX for submit@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:24 -0500 Received: from dd26836.kasserver.com ([85.13.145.193]:59274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwQNL-0006gB-BB for 45403@debbugs.gnu.org; Mon, 04 Jan 2021 08:58:24 -0500 Received: from localhost (80-110-127-104.cgn.dynamic.surfer.at [80.110.127.104]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 7C9CD33656AE; Mon, 4 Jan 2021 14:58:20 +0100 (CET) Date: Mon, 4 Jan 2021 14:58:18 +0100 From: Danny Milosavljevic To: Tobias Geerinckx-Rice via Guix-patches via Subject: Re: [bug#45403] [PATCH] gnu: zfs: Split into packages specific for each of our major supported kernel versions. Message-ID: <20210104145818.0fcd9a0d@scratchpost.org> In-Reply-To: <87tusaa5mf.fsf@nckx> References: <87tusaa5mf.fsf@nckx> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Q/RvIEApKgH6KQhOlJJcvR="; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 45403 Cc: raid5atemyhomework@protonmail.com, Tobias Geerinckx-Rice , 45403@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, 25 Dec 2020 05:09:44 +0100 Tobias Geerinckx-Rice via Guix-patches via wrote: > Worse, there's no such thing as =E2=80=98a 5.10=E2=80=99 Linux module tha= t loads=20 > on =E2=80=98a 5.10=E2=80=99 Linux kernel. We still need an easy generic = method to=20 > build modules against their chosen kernel and configuration. >=20 > As your patch illustrates, that already exists: >=20 > > (define (make-linux-zfs linux-libre) > > (package > > (inherit zfs-base) > > (arguments > > `(#:linux ,linux-libre) > > ,@(package-arguments zfs-base)) =20 >=20 > It just belongs in your system.scm, not in Guix itself. Why is this needed? KERNEL-LOADABLE-MODULES are already automatically adapted in this way. See this in gnu/system.scm : (define* (operating-system-directory-base-entries os) "Return the basic entries of the 'system' directory of OS for use as the value of the SYSTEM-SERVICE-TYPE service." (let* ((locale (operating-system-locale-directory os)) (kernel (operating-system-kernel os)) (hurd (operating-system-hurd os)) (modules (operating-system-kernel-loadable-modules os)) (kernel (if hurd kernel (profile (content (packages->manifest (cons kernel (map (lambda (module) (if (package? module) (package-for-kernel kerne= l <----- modul= e) module)) modules)))) (hooks (list linux-module-database))))) (initrd (and (not hurd) (operating-system-initrd-file os))) (params (operating-system-boot-parameters-file os))) `(("kernel" ,kernel) ,@(if hurd `(("hurd" ,hurd)) '()) ("parameters" ,params) ,@(if initrd `(("initrd" ,initrd)) '()) ("locale" ,locale)))) ;used by libc --Sig_/Q/RvIEApKgH6KQhOlJJcvR= Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl/zHvoACgkQ5xo1VCww uqVN4ggAnf6F7tLDIa3EU200sDCYpVLCX0e+69/Yrio9UiNVtm7wqbjwK9XUelPH +M6FedO9jC29rHv4F1eV0sl9u5sxnuALLW7gO8L6hTRM8DXLpcsfHUB0cJFP8d3h 1LXKJJasu7CaRCC3byYy9vD93o3eBJyz0M39Jalqwwi4KEGz5N53d+wzEx9OKnf6 8nAHbopXePUtt30qW/D2YfirnijjdRuMsaHoYJVSCphT+A1ny3ikuvmOmSDtZttq SImM11fjmljEmbKebyjKflBk97cktS3vKFpjqz2uu0j8u93ACpMYezAeL1r83J2Z UbE8wlCF3xUdKiNiNp/kF78lCw8ZeA== =N9Ts -----END PGP SIGNATURE----- --Sig_/Q/RvIEApKgH6KQhOlJJcvR=--