From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 23:17:47 2020 Received: (at 45252) by debbugs.gnu.org; 28 Dec 2020 04:17:47 +0000 Received: from localhost ([127.0.0.1]:34042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktjyd-0003kV-C1 for submit@debbugs.gnu.org; Sun, 27 Dec 2020 23:17:47 -0500 Received: from mail-pj1-f41.google.com ([209.85.216.41]:50402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktjyb-0003kD-7T for 45252@debbugs.gnu.org; Sun, 27 Dec 2020 23:17:45 -0500 Received: by mail-pj1-f41.google.com with SMTP id lj6so5321486pjb.0 for <45252@debbugs.gnu.org>; Sun, 27 Dec 2020 20:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=oE5NV/jylBBIZmNhd7VhtrtDarvLR0wXeGVJZHGTiDg=; b=rbICKDtr527nf7oOfH5ULU2fvooxKyDq7fLVfJAS2DJtgdWtfoC29WmfFiGWT98lqE qFW/krKF2A1XX7bcJGcxyZSMI6S5J/+RPTAT5mEFBREUjdj3aDwBlWzyQFrlgXCHLTF2 5YhJnNgEQHVaY0UFpx1K1++JNwBmT2SetuJhgty7MY6a/TKhx+kewXE6A9PzACX8YSgH PW/2D1CWZlDgLe++4XlxkzEo1yMVu+kxA27i6bz87YRENEB03DYXPx1zLfEnxNuH3KL0 xwTzlRSxOKGGuvO5SyJKubTV7O8M3qTXb2jmGAV/6Nl2Q7KlK2KFPT2o7ATNDBdTItk/ hHpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=oE5NV/jylBBIZmNhd7VhtrtDarvLR0wXeGVJZHGTiDg=; b=piWcCthno/BAIoXSL9LnL0ZA5u+gZ2OmFVs1SnKvQ2D+Z4lC3xKeuZDNdHKrFmlk37 6e9qddvu/zgu3SRoLv1eW04PUMytCMSOUWp3ItqPkiwwnavukEMIzLTNdMYiYsiAmPN0 eGC7g1tpm8v0LVn6hnBw/GDQW6DhsAD7pd1bOnQzlqbe6DRBPwObC3NRjP8sL1H8dIzx 9P+aDIowa8PnqnhcIyLg3qrPgrQDALAUacApH3iAppoGBRMMiHP8fRy8Zh+7FPxV/Ujl 9AqhN4MhSqwG309LYcJdvS26s0liSaKEKzMsxM9f9+ygsSe2ttmk4IBHwgGjAtWsbjR5 V3aw== X-Gm-Message-State: AOAM531TZd8A6MxBerjLIZX/Ode5xyYC/Jo0R62400YOTlFzfJiYM7za efeJ9J9rkeo0kRiFIlupjKhR3K2RADFrzw== X-Google-Smtp-Source: ABdhPJz4Prhg1u/FHwiPYKnFTZE5Hrg7zweIGCQdTR4bWQZzVVqkTiOyLCzxYuphnz2FbplYr+qi3A== X-Received: by 2002:a17:90a:e38c:: with SMTP id b12mr19535331pjz.177.1609129058734; Sun, 27 Dec 2020 20:17:38 -0800 (PST) Received: from garuda-lan ([2601:601:9d00:688::c9a]) by smtp.gmail.com with ESMTPSA id j14sm12362212pjm.10.2020.12.27.20.17.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Dec 2020 20:17:37 -0800 (PST) From: Chris Marusich To: Efraim Flashner , Mark H Weaver Subject: Re: [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le., [bug#45252] [PATCH] gnu: libffi: Add unreleased patch to fix float128 on powerpc64le. References: <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> <87y2hqifp3.fsf@netris.org> <87tuseidlk.fsf@netris.org> <87r1nhdo2i.fsf@gmail.com> Date: Sun, 27 Dec 2020 20:17:33 -0800 In-Reply-To: (Efraim Flashner's message of "Wed, 23 Dec 2020 09:50:27 +0200, Wed, 23 Dec 2020 16:34:29 -0500, Wed, 23 Dec 2020 16:22:21 -0500") Message-ID: <871rfa36oy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 45252 Cc: guix-devel@gnu.org, John Doe , 45252@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Efraim Flashner writes: > "regular powerpc", ie macppc/ppc32/powerpc-linux-gnu, does have some > bootstrap binaries built but isn't near ready for merging. Go ahead and > make any changes necessary. Mark H Weaver writes: > Hi Efraim, > > Efraim Flashner writes: >> "regular powerpc", ie macppc/ppc32/powerpc-linux-gnu, does have some >> bootstrap binaries built but isn't near ready for merging. Go ahead and >> make any changes necessary. > > I appreciate that, but if rebuilding the world on regular powerpc would > significantly add to the burden of even a single developer, then it's > probably not worth it. I suggested fixing the powerpc64le case now only > because it was just added a few days ago, and more generally to raise > awareness about how best to run the 'patch' program in Guix. > > If it's truly no extra burden, then you could change "--batch" to > "--force" on line 69 of libffi.c (in the "powerpc-*" case). OK. I've made this change on master in commit 662e7e28d576ada91fc9dec7d27c100666114f03. Mark H Weaver writes: > Hi Chris, > > Chris Marusich writes: > >> Mark H Weaver writes: >> >>> Earlier, I wrote: >>>> When invoking 'patch' in Guix, you should *always* use "--force" inste= ad >>>> of "--batch". >>> >>> (See for my earlier message). >> >> Thank you for letting me know about this. I didn't know about the >> difference between "--batch" and "--force". I agree we should use >> "--force" instead of "--batch". How do you recommend that I proceed? > > Simply changing "--batch" to "--force" on line 79 (in the powerpc64le-* > case, i.e. the one that was just added) seems like the right thing. > That will force a rebuild of almost everything on the powerpc64le-* > architecture, but should not cause any rebuilds on other architectures. OK, I've made this change on master in commit fdb90e9ee8a578c88ef3a33067e8a532e43ae7b8. >>> Since writing the message above, I've found another problem in the same >>> commit (7eaa2f24ea77cddbb4bbc2d6a6905673a36f8f99): it searches for the >>> 'patch' program in 'inputs'. This is a mistake, because when >>> cross-compiling, 'inputs' will contain software compiled to run on the >>> target system instead of the build system. >> >> Is it searching for the "patch" program, or is it searching for the >> patch file? It looks to me like the code is searching for the patch >> file in inputs, not the "patch" program. > > LOL, you're right, I got confused. Please disregard my second email in > this thread, and apologies for that noise. No worries! Thanks again for your help. =2D-=20 Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEy/WXVcvn5+/vGD+x3UCaFdgiRp0FAl/pXF0ACgkQ3UCaFdgi Rp1ioQ//W6XnPvkS0isAW+iOAObLeWcNmjN91bKJFKvmNPIxEb2tyVOda/Lv5dJp NFFOziVorczwIORpRJqPSdXIhOfq+bU6ZN9RfY8d20f3Zs7AH7N/rvH7PQUx+N9L GcDHMsDV+fTycgnU9bwPo6q5GGfd9TQy5FGABa5bTsRjCabb/W4iWVW2Vbh3ZVIn PjVmYjq27lLwWTBhyix7GA37sGkIHfm8C4NOFuGaiId9sx5UYjO8nu9vtES53Wq6 frCZ+UHjP2zMfaDA68Q0VonaHA3uqTGpxqdA0EzBJukleDsSl5Tzjnk5MPDGPaHx m/pCoD32IEjOM0q1EWz2EMoop6hackMhtbFVcy7tM06ili4A/XX7I0b2bpZhsbCj 8gbDvNyZqr9w01K1HVyAsepaXzNfV8cNOxAyoQKcFGxUvV+F+EOZPv1eKWEh6ZFd p+h1iJnsjY/xvrCwwh0rTgkw/P4k0o32dROMhF/lqS79pWxFLkXId+kNwwum84Cg 1vhnjpSRIBx5W6c6+xavQovAaSNC9TpuirKeszeG5y6mUpxjAC31oGAI+6NYlJb5 Vw/gQKvVylIS6ma0KkcHlIzcSqqcNX8DlczsV8w5lW+RuzTQ8D5PblFH1zngEH0Y Dgcb/C3BnR1uPUbO4S8IpAv1r2YfaYBlA2146iGn7RGQIHuINt0= =bxVh -----END PGP SIGNATURE----- --=-=-=--