From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 06 16:51:36 2020 Received: (at 45018) by debbugs.gnu.org; 6 Dec 2020 21:51:36 +0000 Received: from localhost ([127.0.0.1]:51540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km1wO-00063g-1v for submit@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1km1wM-00063S-R7 for 45018@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44086) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1km1wH-0007N7-JV for 45018@debbugs.gnu.org; Sun, 06 Dec 2020 16:51:29 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47042 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1km1wG-00054V-Fi; Sun, 06 Dec 2020 16:51:28 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#45018] [PATCH 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query'. References: <20201203101930.11210-1-ludo@gnu.org> <20201203101930.11210-2-ludo@gnu.org> <87wnxynfni.fsf@gnu.org> Date: Sun, 06 Dec 2020 22:51:26 +0100 In-Reply-To: <87wnxynfni.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 04 Dec 2020 09:23:29 +0100") Message-ID: <87czzm4n8h.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 45018 Cc: 45018@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe skribis: >> + (("--substitute" store-path destination) >> + ;; Download STORE-PATH and add store it as a Nar in file DEST= INATION. > > add it to store? Oops. >> + const Strings args =3D { "substitute", "--query" }; >> + const std::map env =3D { { "_NIX_OPTIONS", settings.pa= ck() } }; >> + std::unique_ptrfresh(new Agent(settings.guixProgram, args, env)= ); > > You should prefer make_unique to "new" calls. Apparently =E2=80=98make_unique=E2=80=99 is a C++14 thing and we don=E2=80= =99t build against that standard (yet), so I left it as is. The next patch removes this use of =E2=80=98unique_ptr=E2=80=99 anyway.