From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 28 15:26:46 2020 Received: (at submit) by debbugs.gnu.org; 28 Nov 2020 20:26:46 +0000 Received: from localhost ([127.0.0.1]:49178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj6nu-0002ta-95 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 15:26:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:38922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kj6nr-0002tS-E3 for submit@debbugs.gnu.org; Sat, 28 Nov 2020 15:26:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43574) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kj6nr-0002dd-6k for guix-patches@gnu.org; Sat, 28 Nov 2020 15:26:43 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:39690) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kj6np-0004t4-Ij for guix-patches@gnu.org; Sat, 28 Nov 2020 15:26:42 -0500 Received: by mail-wr1-x436.google.com with SMTP id e7so9479318wrv.6 for ; Sat, 28 Nov 2020 12:26:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eMlxRmzGNNys8nycchSj1AooB/tJaJpsHUKkk+ILKAM=; b=GaFtb0xMfw0IdApdayC1K17pyZ4q+72wrJaMP4v9tgnVqQ1r7cfhus+dacRJDDBkjG v2sm7WkJ2lK0+cS2OWZ3xMYDAutdyzE9zhvc6o5pX8XgSCle6PoneUDNAHBZv3rkTwCO 5pEdrXXzqYEoDp9jPgzLXPwkCW5lssowid6Z6E/w1DwiepVpYqGw5Q6Tn1R8mUlaWpCU wEZ2NoG+j4d9Ce+3tRRWznx4n8KfUWUbyVnNNjTPG9C7Iz+MLFK0o0Cnyzj2H9U4fg2B DDikTWLoYkvZ/NqDBtJdIPDdcl+4Ch1xHz48KRUqO2fmkbDO3CrXYvYf3LQLI07PL8IC Romw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eMlxRmzGNNys8nycchSj1AooB/tJaJpsHUKkk+ILKAM=; b=F+Ak5drMbCghkN53sMXJZBSSRGvhow2aE/ODVTwprPbuo4WMCvwNIcD+ZD1x0wdCXl Sb98jMU5ypOdf1N6vK0Wr8mcD8THalVN0b9s9YWiMHaKjQN170XyrOe7SH6kcEY9escA 78+fE2HXilwZ+zhIMro/GrRHuUREcPApXarf07xPNx7njfGgEtCKYbKct2ZyQDlq99sx KML5eWMeA3oW/NGy9A82KlFU0+VTACbblRmhs0xjBtCq+NqRLadqWIqkNNqjbxF51RUL SXPjq6Y0CjcBUPE1bMG1v61IxphWi0ttatiXYAQeuOg/iGUCTpNOzT2FWbRdm2rEseLk bHXQ== X-Gm-Message-State: AOAM531tjKCaWAWxXTOjIoVYLEf4ngthHcA3B3UOA6OXwwvZJak+UIqD vkuBoq2rn+Ej/HrK6hbDBtHleTtasQhzAw== X-Google-Smtp-Source: ABdhPJzYx3iGKYb47kJF42Zm+wdSe06+yzuaRARkpgUF+PrglS9aiAsm3b5q2ZWmEN76zOegYdmhmA== X-Received: by 2002:adf:fd52:: with SMTP id h18mr19056200wrs.90.1606595199887; Sat, 28 Nov 2020 12:26:39 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id i11sm22077921wrm.1.2020.11.28.12.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Nov 2020 12:26:39 -0800 (PST) From: zimoun To: guix-patches@gnu.org Subject: [PATCH 0/1] upgrade: Allow several regexps (fix #44928). Date: Sat, 28 Nov 2020 21:26:31 +0100 Message-Id: <20201128202631.27734-1-zimon.toutoune@gmail.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=zimon.toutoune@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: zimoun X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Dear, Fixes describing that the 2nd raises an error: $ guix upgrade foo bar guix upgrade: error: bar: extraneous argument And it is not the case with "guix package -u foo bar". I am not convinced by the patch but after thinking a bit, the 'match' does not seem necessary because the options are correctly handled by SRFI-37 and any extra term is potentially an other regexp. The 'opts' is correctly formed and then "guix-package" does all the job. Well, I have been too lazy to create something in the test suite; someone should do. :-) Testing "guix package --upgrade" and "guix upgrade". Maybe a v2 of this tiny patch? ;-) Feedback welcome. All the best, simon zimoun (1): upgrade: Allow several regexps. guix/scripts/upgrade.scm | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) base-commit: 8ea2d7c2fa4d4ad7b4cf522fa259561beeeda072 -- 2.29.2