On Thu, 2020-11-26 at 23:31 +0100, Ludovic Courtès wrote: > Hi, Hello! > dftxbs3e skribis: > > > From e195e9e9fe0409dd4b76cac87244cb2b5d7636e0 Mon Sep 17 00:00:00 > > 2001 > > From: John Doe > > Date: Sat, 21 Nov 2020 17:06:07 +0100 > > Subject: [PATCH] gnu: libffi: Add unreleased patch to fix float128 > > on > >  powerpc64le. > > > > Patch fetched from https://github.com/libffi/libffi/pull/561.patch > > Bonus points for a ChangeLog-style commit message.  :-) >   > https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html > Sorry, it's not clear to me yet what that is yet, will read again. > The patch LGTM, but I vaguely remember seeing similar patches by > Efraim > in a branch (?), or was it for 32-bit PowerPC? > > If there’s no collision with other patches in this area, we can > happily > apply it. > There's no collision, Efraim's patch is and mine is . Efraim's patch is about POWER7 and earlier. There's quite a few PRs relating to PowerPC bugs on libffi: https://github.com/libffi/libffi/pulls?q=is%3Apr+powerpc+is%3Aclosed > Ludo’. Thanks a lot for the review! Attached new patch version, I hope it is better with the commit message now.