From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 19 16:40:20 2020 Received: (at 44741) by debbugs.gnu.org; 19 Nov 2020 21:40:20 +0000 Received: from localhost ([127.0.0.1]:41190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfrf9-0000z9-Qx for submit@debbugs.gnu.org; Thu, 19 Nov 2020 16:40:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kfrf7-0000yt-M6 for 44741@debbugs.gnu.org; Thu, 19 Nov 2020 16:40:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34594) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kfrf2-0006Vn-FC for 44741@debbugs.gnu.org; Thu, 19 Nov 2020 16:40:12 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37258 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kfrf2-0004DG-0g for 44741@debbugs.gnu.org; Thu, 19 Nov 2020 16:40:12 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 44741@debbugs.gnu.org Subject: Re: bug#44741: =?utf-8?Q?=E2=80=98copy-recursively=E2=80=99?= #:keep-mtime? #t broken for directories References: <87mtzdgvyq.fsf@inria.fr> Date: Thu, 19 Nov 2020 22:40:08 +0100 In-Reply-To: <87mtzdgvyq.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Thu, 19 Nov 2020 17:19:57 +0100") Message-ID: <87ima1gh53.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44741 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > When passing #:keep-mtime? #t to =E2=80=98copy-recursively=E2=80=99, the = mtime of > regular files is preserved, but the mtime of directories (and symlinks) > is not. > > This is because =E2=80=98set-file-time=E2=80=99 is called in the =E2=80= =98down=E2=80=99 procedure of > =E2=80=98file-system-fold=E2=80=99, before the directory is populated. Fixed by 201cbcac3e9c23cc28352fa9ece3e677e22cc12c (core-updates). > =E2=80=98populate-store=E2=80=99 is affected by this bug, meaning that it= creates stores > where directories have =E2=80=9Cwrong=E2=80=9D timestamps. In practice t= his is probably > less likely to have undesirable side effects than regular files with > wrong timestamps (think =E2=80=98make=E2=80=99, .go files, etc.) In some cases, such as the initrd, the problem is harmless because timestamps are reset anyway in the archive (for instance =E2=80=98write-cpio-archive=E2=80=99 does that.) There might be problems in other cases, such as (gnu build image). Ludo=E2=80=99.