From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 07:50:34 2020 Received: (at 44169) by debbugs.gnu.org; 23 Oct 2020 11:50:34 +0000 Received: from localhost ([127.0.0.1]:56182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVvac-0005nt-3d for submit@debbugs.gnu.org; Fri, 23 Oct 2020 07:50:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVvaa-0005nb-Bz for 44169@debbugs.gnu.org; Fri, 23 Oct 2020 07:50:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45479) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kVvaU-0004qK-Ag; Fri, 23 Oct 2020 07:50:26 -0400 Received: from [2a01:e0a:19b:d9a0:50c1:4a69:300e:4531] (port=58376 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kVvaT-0005w0-Iq; Fri, 23 Oct 2020 07:50:25 -0400 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#44169] [PATCH 3/3] installer: Use UUIDs in the 'swap-devices' field. References: <20201023100754.20924-1-ludo@gnu.org> <20201023100754.20924-3-ludo@gnu.org> Date: Fri, 23 Oct 2020 13:50:24 +0200 In-Reply-To: <20201023100754.20924-3-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Fri, 23 Oct 2020 12:07:54 +0200") Message-ID: <87imb1i2kf.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44169 Cc: 44169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > + `((swap-devices (list ,@(map (lambda (uuid) > + `(uuid ,uuid)) > + uuids)))))) I fear that this will break the "gui-installed-os" test. The "installation-target-os-for-gui-tests" procedure declares "/dev/vda2" as swap-device, while the installer will declare it using an UUID. This mismatch will probably make "shepherd services" test unhappy. We could maybe set a swap label during installation and use it in the installer tests? Thanks, Mathieu