From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 20 07:51:50 2020 Received: (at 44077) by debbugs.gnu.org; 20 Oct 2020 11:51:50 +0000 Received: from localhost ([127.0.0.1]:43819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUqBC-0004sK-85 for submit@debbugs.gnu.org; Tue, 20 Oct 2020 07:51:50 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:57885) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUqBA-0004s4-96 for 44077@debbugs.gnu.org; Tue, 20 Oct 2020 07:51:49 -0400 X-Originating-IP: 176.137.73.130 Received: from localhost (chr13-h03-176-137-73-130.dsl.sta.abo.bbox.fr [176.137.73.130]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 205D440002; Tue, 20 Oct 2020 11:51:40 +0000 (UTC) From: Nicolas Goaziou To: Tanguy Le Carrour Subject: Re: [bug#44077] [PATCH 1/2] gnu: Add python-poetry-core. References: <20201019132649.13548-1-tanguy@bioneland.org> <20201019132912.13941-1-tanguy@bioneland.org> Date: Tue, 20 Oct 2020 13:51:40 +0200 In-Reply-To: <20201019132912.13941-1-tanguy@bioneland.org> (Tanguy Le Carrour's message of "Mon, 19 Oct 2020 15:29:11 +0200") Message-ID: <87zh4h6roz.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44077 Cc: 44077@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Tanguy Le Carrour writes: > * gnu/packages/python-xyz.scm (python-poetry-core): New variable. Thank you. > +(define-public python-poetry-core > + (package > + (name "python-poetry-core") > + (version "1.0.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "poetry-core" version)) > + (sha256 > + (base32 > + "1mgv276h1iphn5fqhp2sgkgd5d0c39hs33vgaf157x5ri7rlyrka")))) Nitpick: move the string on the same line as `base32'. > + (build-system python-build-system) > + (home-page "https://github.com/python-poetry/poetry-core") > + (synopsis "Poetry PEP 517 Build Backend") Nitpick: I would avoid unnecessary capitalization: Poetry PEP 517 build back-end > + (description > + "A PEP 517 build backend implementation developed for Poetry. This project > +is intended to be a light weight, fully compliant, self-contained package allowing > +PEP 517 compatible build frontends to build Poetry managed projects.") The first sentence should be complete, i.e., with a subject and a verb. Otherwise, LGTM. Regards, -- Nicolas Goaziou