From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 10 07:59:25 2020 Received: (at 43893) by debbugs.gnu.org; 10 Oct 2020 11:59:25 +0000 Received: from localhost ([127.0.0.1]:37065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRDX2-00042Q-MQ for submit@debbugs.gnu.org; Sat, 10 Oct 2020 07:59:25 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:50640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kRDWx-00042C-Uc for 43893@debbugs.gnu.org; Sat, 10 Oct 2020 07:59:22 -0400 Received: from localhost (80-110-126-103.cgn.dynamic.surfer.at [80.110.126.103]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 253743361700; Sat, 10 Oct 2020 13:59:17 +0200 (CEST) Date: Sat, 10 Oct 2020 13:59:13 +0200 From: Danny Milosavljevic To: Maxim Cournoyer Subject: Re: bug#43893: [PATCH] maint: update-guix-package: Ensure sources are clean. Message-ID: <20201010135913.6d0e02d5@scratchpost.org> In-Reply-To: <20201010050852.19975-1-maxim.cournoyer@gmail.com> References: <87eem7qcxc.fsf@gmail.com> <20201010050852.19975-1-maxim.cournoyer@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/zlSATVCbyCgHxzNW/Qe==Mr"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 43893 Cc: 43893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/zlSATVCbyCgHxzNW/Qe==Mr Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Maxim, hmm, git worktree can fail if the commit already is checked out somewhere (= for example if you invoke make update-guix-package twice in a row), or if the u= ser used git worktree on that repo for that commit for other purposes. That wo= uld mean that make update-guix-package would fail in weird undocumented ways again. Please please let's document stuff at least. Also, why not just fail when there's uncommitted stuff? This patch looks like it goes to quite some length to enable you to build a guix package of committed stuff only (which is NOT what your working copy is actually like). Is there a use case for that? Sounds weird to me. Even if there's a use case for that, please add a warning if there are uncommitted changes that are now not included in the "guix" package. Other than that, okay. >#FIXME: This doesn't work (recursion?) >./pre-inst-env guix build guix --with-git-url=3Dguix=3Dfile://$PWD Why doesn't it work? That sounds like a big limitation--that basically mea= ns you can't test with local-only commits, you'd always have to push. We should find out why this doesn't work and fix it. --Sig_/zlSATVCbyCgHxzNW/Qe==Mr Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl+BohEACgkQ5xo1VCww uqWhjQf/csexxtAxHPK5c56adbbkonAjGkOTJ+D9THjRt14TPiUH84HMYhhT02Sd pLpl1I5ZQX/5sxsoXj5xWcMC2LEZGVP9wgqieXVTx9GA8i+HDatco7YVKKKW/22n ZAAW49MFf2zT3rlOEedWeCFXWOk1B+jy+odSDp7KHceIsDvl7uBYTTvqqU5J4Qpc NPmXXv4Cr/Itg84VlGkjfqmLUwbY4VSk3diexP/kApcb6p/e4d44Ld06LoNGGECR +i5rRLvjYQ+4dGM5Xp61juNoAIciqcMBRUTUmGT2+YpIcJG8WfGIWx946lV5XPfh i2EDgAMc9WJmwRczooyXR6jM7VIWcA== =q0DZ -----END PGP SIGNATURE----- --Sig_/zlSATVCbyCgHxzNW/Qe==Mr--