From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 04:33:02 2020 Received: (at 43893) by debbugs.gnu.org; 10 Nov 2020 09:33:02 +0000 Received: from localhost ([127.0.0.1]:36358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcQ1O-0006vW-7C for submit@debbugs.gnu.org; Tue, 10 Nov 2020 04:33:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcQ1M-0006uz-Pb for 43893@debbugs.gnu.org; Tue, 10 Nov 2020 04:33:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57828) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcQ1H-00030B-GN; Tue, 10 Nov 2020 04:32:55 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=42702 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcQ1H-0005xd-47; Tue, 10 Nov 2020 04:32:55 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH v5] maint: update-guix-package: Optionally add sources to store. References: <871rhevfpp.fsf@gnu.org> <20201109224443.27495-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 20 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 10 Nov 2020 10:32:53 +0100 In-Reply-To: <20201109224443.27495-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Mon, 9 Nov 2020 17:44:43 -0500") Message-ID: <871rh1r1yy.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43893 Cc: 43893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > Following discussions in , keeping a c= opy > of the updated package source is desirable when generating a release. > > * build-aux/update-guix-package.scm (version-controlled?): Remove variabl= e. > (call-with-temporary-git-worktree): Renamed from > 'with-temporary-git-worktree'. Update doc. Do not change directory > implicitly. > (keep-source-in-store): New procedure. > (main): Adjust to use with call-with-temporary-git-worktree. Add the sou= rces > to the store when GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT is set. Exit grace= fully > when FIND-ORIGIN-REMOTE returns #f. > (%savannah-guix-git-repo-push-url-regexp): Adjust match for a potential c= olon > separator. > * Makefile.am (GUIX_ALLOW_ME_TO_USE_PRIVATE_COMMIT): Adjust. > * .dir-locals.el (scheme-mode): Update. > * doc/contributing.texi (Updating the Guix Package): Update doc. > > Co-authored-by: Ludovic Court=C3=A8s Go for it, thanks! Ludo=E2=80=99.