From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 11:11:17 2020 Received: (at 43630) by debbugs.gnu.org; 28 Oct 2020 15:11:17 +0000 Received: from localhost ([127.0.0.1]:50117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXn6a-0002GK-PR for submit@debbugs.gnu.org; Wed, 28 Oct 2020 11:11:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXn6Y-0002G8-Qo for 43630@debbugs.gnu.org; Wed, 28 Oct 2020 11:11:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45957) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXn6T-0005Q4-Jv; Wed, 28 Oct 2020 11:11:09 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44628 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXn6T-0002zi-4J; Wed, 28 Oct 2020 11:11:09 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Gabriel Arazas Subject: Re: [bug#43630] [PATCH] gnu: Add tic-80. References: <20200926101738.18925-1-foo.dogsquared@gmail.com> <20200926101738.18925-2-foo.dogsquared@gmail.com> Date: Wed, 28 Oct 2020 16:11:07 +0100 In-Reply-To: <20200926101738.18925-2-foo.dogsquared@gmail.com> (Gabriel Arazas's message of "Sat, 26 Sep 2020 18:17:38 +0800") Message-ID: <87lffq1j3o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 43630 Cc: 43630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Gabriel, Sorry for the long delay! Gabriel Arazas skribis: > * gnu/packages/game-development.scm (tic-80): New variable. [...] > + (description > + "A fantasy computer featuring built-in tools such as a sprite edito= r, > +music tracker, and a text editor. This package builds the free version = of the > +software which you can override the package and build the PRO version > +yourself.") We need full sentences and, as per the FSDG, we won=E2=80=99t advertise the =E2=80=9CPRO=E2=80=9D version (which is non-free I guess?) here. So instea= d I propose this: (description "TIC-80 is a fantasy computer for making, playing and sharing tiny gam= es. There are built-in tools for development: code, sprites, maps, sound editors and the command line, which is enough to create a mini retro game. At the exit you will get a cartridge file, which can be stored and played on the website.") Another issue: the code bundles quite a few libraries. We should remove them in a snippet and use the corresponding packages instead. Here=E2=80= =99s what I see in the log: --8<---------------cut here---------------start------------->8--- Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/sdl2'... Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/sokol'... Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/squirrel'... Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/wren'... Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/zip'... Cloning into '/gnu/store/hb5kz8vrk5ykyc3xmx30h20f2bm7pmcp-tic-80-0.80.1344-= checkout/vendor/zlib'... --8<---------------cut here---------------end--------------->8--- =E2=80=98sokol=E2=80=99 and =E2=80=98wren=E2=80=99 are apparently not packa= ged yet in Guix. As a first step, you could remove everything but these two libraries, leaving a FIXME about them. Could you send an updated patch? Thanks, Ludo=E2=80=99.