From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 26 08:08:38 2020 Received: (at 43277) by debbugs.gnu.org; 26 Sep 2020 12:08:38 +0000 Received: from localhost ([127.0.0.1]:46000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM90I-0001sL-Af for submit@debbugs.gnu.org; Sat, 26 Sep 2020 08:08:38 -0400 Received: from mail-bn7nam10olkn2043.outbound.protection.outlook.com ([40.92.40.43]:4864 helo=NAM10-BN7-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kM90F-0001s6-Fl for 43277@debbugs.gnu.org; Sat, 26 Sep 2020 08:08:37 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HSneBfQ//EFCkGSnvUvjnElhCkEcmh6IlCTF2qLdbeF6mw876+YhEpjJXWDNp0VxZougT5Bgvb5fY4jCpcjZWJyVDw3MH60MC6LxJVj1rkvtF+/SB1lm0LgE18wkzugyUgoL7mLNvqyecM3mJ2PpqkiC5+q+qG4XmYc5lwQe6a44IvZsuuFbf37yoPQEa7NDeqRu0cF3LivzAmWqExLyFigCpUhvNg44Im2nK2WRqQdgsVMGlSylFpMQZUDPk78zFGrlfX+vBZOP8mnl892eAvTRzs6EcdF5NrzgQ24i7qRb6QV0Xz33xqqqrzs7QWxYbHo7QEfT6p3xv3S6N90m/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBNtM7XpbL2Rybu9uACtZpuxICPBDo5fHvfNHBogiZQ=; b=h/RWSy5PS5nHYLcsVDMu/Wnlo9YUftOhoY1kBDUgfO+1OuHEAQIuITyW7mQ0lMB8ayM5KyDVnD+FH0RBOwD28uwTUAHXYtdiDT/Xz9KgMMvYHjC/f59BHoRgbVYeu1VVoJC3NesioE2bQdy6akuF2C4udfV4/OwtxOFvb6cPIR4iGo7kedYaWvXQxBZype477or+yr5lV1w8neRc/3nv94H/7netfJWDhWcFC6vcRBCdvF1Z0cUH/VObGH/DgMCPSb6GO12C19Xum3M3Ub8TKplyyAhK8zBP5PDc1Ie/mpBJdZFpI9eTUPoJDF2tjokHTR4clGfWKmfgaiq9TIp/+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tBNtM7XpbL2Rybu9uACtZpuxICPBDo5fHvfNHBogiZQ=; b=W37G3Ep6O8UBo8ComySDLYNzXihDisBnp+2moJTIdj4E/QRwcrGnfC4dtbC4IlPMlSphsuRyljWYkznWKSDKPmMqlf+bpw1XuJWU2K8PjfxIavgfFpgzuJ25bcwsj4m1CBbkK39mdpgbvu5go5V2hcfmN2yAjXwFcdvCMqej9hIg9n3YKLyZ0LQVx8bzUpY3yAefdjZTGCML+YVHbE6nAZZxjjlMW8JT2DUK+6JUDctW8zc/+11inTVnRUnuqzGYw1qyHpvWP1jm0yJ5FYrUglXCjuHXGhfC3zsLRatQwyzak6NDSKNJHdqFja3sKbXzHChnYeA6ELzOqPvDlBbMUQ== Received: from MW2NAM10FT017.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::41) by MW2NAM10HT086.eop-nam10.prod.protection.outlook.com (2a01:111:e400:7e87::285) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Sat, 26 Sep 2020 12:08:29 +0000 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com (2a01:111:e400:7e87::49) by MW2NAM10FT017.mail.protection.outlook.com (2a01:111:e400:7e87::478) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Sat, 26 Sep 2020 12:08:29 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:A95F73291B1E5D5FB0D1A0E7C83187E7DE17E3375B590FB762CABF3B98A0D728; UpperCasedChecksum:83775A8394F2A50A75D28D47F96B64B9972321A25B8F580AB4BA1750A91AF56F; SizeAsReceived:7628; Count:47 Received: from DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::cc1a:65a6:d74d:52f4]) by DM5PR1001MB2105.namprd10.prod.outlook.com ([fe80::cc1a:65a6:d74d:52f4%6]) with mapi id 15.20.3391.028; Sat, 26 Sep 2020 12:08:29 +0000 From: Morgan Smith To: Pierre Langlois Subject: [PATCH] gnu: emacs-next: Fix load path and version References: <87pn6dslqh.fsf@gmx.com> Date: Sat, 26 Sep 2020 08:08:23 -0400 In-Reply-To: <87pn6dslqh.fsf@gmx.com> (Pierre Langlois's message of "Tue, 22 Sep 2020 19:35:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: YT1PR01CA0054.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::23) To DM5PR1001MB2105.namprd10.prod.outlook.com (2603:10b6:4:2b::24) X-Microsoft-Original-Message-ID: <87lfgwbv0o.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pancake (45.58.219.194) by YT1PR01CA0054.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:2e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.21 via Frontend Transport; Sat, 26 Sep 2020 12:08:28 +0000 X-Microsoft-Original-Message-ID: <87lfgwbv0o.fsf@outlook.com> X-TMN: [eni8YPm+67EJ+FD8Xy0x44RaXMaEQ4DH] X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: be8e2760-ce95-4cbb-4415-08d86214e12e X-MS-TrafficTypeDiagnostic: MW2NAM10HT086: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qFfY7wSn02JY2a9DeVfwTVN/c/a5ISTD3fIKy+NsAeKkrkO5uU0jZV3MX22py1oFAW0S/rr8ZaGVAFxUAIaOoA5LsExTVIz1go0ZW9uGwkSgkOfp5zfkUYFpSxmZWvZ/B7zArZ9q+tm48fYvF6JZtBW71U8cGTpZleq6r+XFwycodEBgxWZyB/LIdMR+L+6A9qRMvM9NVommAAc3p9piAg== X-MS-Exchange-AntiSpam-MessageData: Ifud6+E4U6HIXmDk0+Z3nOO85b8i8CKBkbA0zC6vSKtqr1/zsI0tBOPut1dpAue+PJbZMXxd0HJNp8GleDGc2HzHrQSDmakP7IkHQUkLO+3bNOJeBA/Dd2Dk2b/HYbmIWOXGND0i7Ynhkvhf3jjqAA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: be8e2760-ce95-4cbb-4415-08d86214e12e X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2020 12:08:29.3636 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: MW2NAM10FT017.eop-nam10.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM10HT086 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 43277 Cc: malte.f.gerdes@gmail.com, mike@rohleder.de, 43277@debbugs.gnu.org, mjbecze@riseup.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Pierre, Thanks for the feedback! Pierre Langlois writes: > I agree in general it's good to reuse code, however in this particular > case it's probably better to keep the phases duplicated. For example, > in the future one could update the emacs-next package to not require a > revision number anymore, and it's likely they'd forget to update the > emacs package since it'll still work. > > Does that make sense? It might be just a matter of taste, I don't have a > super strong opinion on this. It's important to realize that this is what caused the current problem to begin with so in a way I agree. However, I think there is a big difference between code that fails silently, and code that fails loudly. The native search paths failed "silently" since the package still built and even appeared to work (since the normal emacs with in my path). copy-file, thankfully, fails very loudly since the package simply won't build if it can't find the file to move. Plus the error message is quite good (It can't find the file). For this reason, it's likely a good thing that the native search paths code is duplicated, but I think the stip-double-wrap phase should be reused. Thanks, Morgan