From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 15 16:49:41 2020 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 20:49:42 +0000 Received: from localhost ([127.0.0.1]:60678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtV-00030s-PT for submit@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:41 -0400 Received: from world.peace.net ([64.112.178.59]:42082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIHtU-00030b-FG for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 16:49:40 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIHtO-0000C1-9R; Tue, 15 Sep 2020 16:49:34 -0400 From: Mark H Weaver To: Efraim Flashner , Mike Rosset Subject: Re: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. In-Reply-To: <87ft7ibwpz.fsf@netris.org> References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> Date: Tue, 15 Sep 2020 16:48:17 -0400 Message-ID: <87d02mbwb7.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 43232 Cc: 43232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Earlier, I wrote: > In contrast, a call to 'substitute*' will silently start doing nothing, > and may easily be forgotten. To make matters worse, a future version of > jack-2 might add another 'for' loop in that file, matching the same > pattern but where it is important that 'i' _not_ be initialized to 0. Sorry, I made a mistake in the details here, since the pattern applies only when 'i' is already initialized to 0, but the more general point still stands, namely that patches are more robust than 'substitute*' for fixing bugs, and less likely to be misapplied or left forgotten in a vestigial state after they are no longer needed. Mark