From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 05 21:30:22 2021 Received: (at 42885) by debbugs.gnu.org; 6 Apr 2021 01:30:22 +0000 Received: from localhost ([127.0.0.1]:38883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTaXu-0005e0-0R for submit@debbugs.gnu.org; Mon, 05 Apr 2021 21:30:22 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]:27642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTaXr-0005dk-F1 for 42885@debbugs.gnu.org; Mon, 05 Apr 2021 21:30:20 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4FDqhj1F7pzQjn4; Tue, 6 Apr 2021 03:30:13 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brendan.scot; s=MBO0001; t=1617672611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H6XYDE+7LFaOqOse7GH2dToj3yqwFXy2xUUIWv7DbWk=; b=p9BtSYkGnEhocwEvAcRt3iCb5ENqnp2hxbpeMyCxdunp4P/jHUVKXuCIbvfuFRb1R5K5s3 +DZnrKniNoKew/yOgjn5npFlfW8En8VE+WEIgglUvjbX1iHPugKN26HBSAy7dhOHIP0/cR 2HASAGm9w37PxRwXiklmOLkPwCejXvoax03KiT7NH/CrzElBXC3B+H4LEJ9pkw6S2e9aUE qhGLCvnR6bhwa1x6QTZW6Xc/1Wd/Qilr6qCliTNiodh1pwq/IYDyI5PhsmyEV6FTc1aADh 7+1VeFLSVG5FN1OUaLfMktN/UjFwxbvZSV4Z91Byu4KhqSS6qTMLvBJpdp2SaA== Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter05.heinlein-hosting.de (spamfilter05.heinlein-hosting.de [80.241.56.123]) (amavisd-new, port 10030) with ESMTP id KqoxojzLpiRt; Tue, 6 Apr 2021 03:30:08 +0200 (CEST) Date: Tue, 6 Apr 2021 03:30:08 +0200 (CEST) From: Brendan Tildesley To: Leo Famulari Message-ID: <1191049121.29289.1617672608111@office.mailbox.org> In-Reply-To: References: <20210310090053.21612-1-mail@brendan.scot> <20210310090053.21612-23-mail@brendan.scot> <1277129883.83284.1616552006895@office.mailbox.org> <327102377.27084.1617085423564@office.mailbox.org> Subject: Re: [bug#42885] [PATCH 23/27] gnu: calibre: Update to 5.13.0. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-MBO-SPAM-Probability: X-Rspamd-Score: -5.86 / 15.00 / 15.00 X-Rspamd-Queue-Id: AE7E4387 X-Rspamd-UID: 71ba5e X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42885 Cc: 42885@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On 04/05/2021 9:58 PM Leo Famulari wrote: [...] > If I understand correctly, the issue that any package that uses > python-pyqt5 also needs to be able to find python-pyqt5-sip. Is that > right? > > If so, it sounds like a case for propagated-inputs [0]. Concretely, I made > python-pyqt5-sip a propagated-input of python-pyqt and removed the > 'pyqt5-sip' phase, and Calibre built successfully. > > Does that seem like the right approach? > Sounds good. I didn't realise propagated-inputs did that, I thought they were just normal inputs that were installed along side the package in a profile, but wouldn't make a difference during build time. Does this mean all packages that depend on python-pyqt5 will have python-pyqt5-sip added to its own list of inputs in their own package definition? If so the manual doesn't mention that. > > The reason I added qtsvg was to try fix the Qt test. If you remove the > > line (setenv "SKIP_QT_BUILD_TEST" "true"), this test fails for > > multiple reasons. One of them was qtsvg missing. Another was the > > get_exe_path bit. But a third reason I that its call to printtopdf in > > pyqtwebegine returns an empty string instaed of b'Skia/PDF'. I had no > > idea how to proceed with fixing that so I left it for now. But at > > least fixed the other errors. I assume some SVG related functionality > > will fail without it... > > That's a good point. However, I checked if the built Calibre refers to > qtsvg, and it doesn't [1]. So, it's unlikely that Calibre will be able to > find and use qtsvg, regardless of whether or not it's an input. So, I'd > prefer to leave it out until we understand what it's for and how to make > sure that Calibre can use it. I see, that's a good trick for checking references.. Leave svg out for now then. > > > All good I think. My descriptions were much worse than I realised. > > No worries. Writing the synopses and descriptions is a completely > different type of work from packaging or programming. I often "finish" > some packages, but need to go back later to write the descriptions. I'm > happy to finish these tasks as part of the code review process. > I find writing them the most stressful part because I sit there not knowing what to write. > > python-cchardet differs from in python-chardet in that its not written > > /in/ python, but links to a fast C library to do it, but your > > description/synopsis changes make it look like its all in > > Python. Maybe make the description: > > > > "cChardet is a character encoding detector, binding to the C > > library uchardet for speed." ? > > Thanks, that helps. I amended the synopses and description based on > this. > > I pushed my revisions of your updated branch, rebased on the current > master branch, to Savannah: > > https://git.savannah.gnu.org/cgit/guix.git/log/?h=wip-update-calibre > > [0] > https://guix.gnu.org/manual/en/html_node/package-Reference.html > > [1] This command be used: > $ guix gc --references $(./pre-inst-env guix build --no-grafts calibre) | grep qtsvg