From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 30 15:51:53 2020 Received: (at 42849) by debbugs.gnu.org; 30 Aug 2020 19:51:53 +0000 Received: from localhost ([127.0.0.1]:50806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTMn-0005f5-2F for submit@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kCTMl-0005et-LZ for 42849@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kCTMg-0007PT-Cg for 42849@debbugs.gnu.org; Sun, 30 Aug 2020 15:51:46 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=43516 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kCTMf-0006NO-Fn; Sun, 30 Aug 2020 15:51:45 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#42849] [PATCH 1/3] install: Factorize cow-store procedure. References: <20200813122323.262805-1-othacehe@gnu.org> <20200813123419.263639-1-othacehe@gnu.org> Date: Sun, 30 Aug 2020 21:51:44 +0200 In-Reply-To: <20200813123419.263639-1-othacehe@gnu.org> (Mathieu Othacehe's message of "Thu, 13 Aug 2020 14:34:17 +0200") Message-ID: <87wo1fhpyn.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42849 Cc: 42849@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: > Move the cow-store procedure from the service declaration in (gnu system > install) to (gnu build install), so that it can be called from within a > different context than Shepherd. > > * gnu/build/install.scm (mount-cow-store, umount-cow-store): New procedur= es. > * gnu/system/install.scm (make-cow-store): Remove it, > (cow-store-service-type): adapt it accordingly. Nitpick: Unlike K&R back then, I think we can afford the =E2=80=98n=E2=80= =99 in =E2=80=98unmount=E2=80=99. :-) Other than that LGTM! Ludo=E2=80=99.