From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 05 07:09:26 2021 Received: (at 42771) by debbugs.gnu.org; 5 Jan 2021 12:09:26 +0000 Received: from localhost ([127.0.0.1]:40982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwl9R-0005Bw-SS for submit@debbugs.gnu.org; Tue, 05 Jan 2021 07:09:26 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:50831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwl9P-0005Bg-Vl for 42771@debbugs.gnu.org; Tue, 05 Jan 2021 07:09:24 -0500 Received: by mail-wm1-f51.google.com with SMTP id 190so2825416wmz.0 for <42771@debbugs.gnu.org>; Tue, 05 Jan 2021 04:09:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=e8ouqNlzT5FLir99Q3o6HPeHUGs0lV4avhxnGcl617Y=; b=Q7qNfETXkbUmi8f4Bo8T931/FF0TgWfrWCF5uEzfIJf64Z76H/PtNAnRBP7hFmV5yQ KtU6gs144HW2jUU/QDKnAn1Yq5Q1u1rt4f3fjJTsTQ0Pq9TQ/R0nuC1r1HzFRhOUzeyD MinUa4sRuL7nbjghwpBA2tcA29xcWXxXxemTPkt3Y6bl69j5WTMMeDdyKyoA5MVqRQRn uQ1cV86wOlTKmDjzz9HYCJiHSzu9ujNlWN5WFY9XVnCDkjZdi35KiCAPaXNBbEVj/jam FUQJ8dpwh/7bB2lu2KBu+ojEn7FTWEaBNuZbKbIWGQAS1LIOS+xgubvjSHUeFpwKfFLt o9Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=e8ouqNlzT5FLir99Q3o6HPeHUGs0lV4avhxnGcl617Y=; b=lyenHtxbt7Nwf54OfcIjUnwsL0AvuLjGzEQPLuUYwoG/I/6tEbSY+9/ZbAspl7+qio Hk9i0eWML8mIc7n7JVqfldSVbrw8HSEcNvYn16eKuzjKkv+BicbZU3qL2T9Keh8hFfwK NQkxhPTOBbyiWEB21NZKU+dDheqMa19/G2VbAAWrFI0a/YsBUJ+b8ksoKZsLIpDhkNnB nLwDYfvasZcdWBpSH8OGepUz5V8a++Q1g1HcZASS7u9t9C9N+58YlM1ooTtJiZ3XIIp/ apFUERjlrIpsdY7Y74FjetYFBjsts4J+Q01707KqMipI4B3Dfc/yJF0h3kMhSw1PsWjJ q5/Q== X-Gm-Message-State: AOAM533cDspsNtD5kAl406YNrUaHwOI31LTLsY5CjoSsVFftR87RM703 +GmN8Pbc7mgwWvKXI9FM0SCuQHwg7tw= X-Google-Smtp-Source: ABdhPJz0KYFFrHX/QXKWesvkTx2AI9a/7Mp2G9xYUym/8Ew4Vqdzfq3w+A2qU7Qw0J6XvfyNr2nhpA== X-Received: by 2002:a1c:1d1:: with SMTP id 200mr3295233wmb.98.1609848557989; Tue, 05 Jan 2021 04:09:17 -0800 (PST) Received: from unfall (36.193.158.146.dynamic.jazztel.es. [146.158.193.36]) by smtp.gmail.com with ESMTPSA id g78sm3899024wme.33.2021.01.05.04.09.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jan 2021 04:09:17 -0800 (PST) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#42771: smalltalk fails to build References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> <87mtys72bw.fsf@gnu.org> <877dp240n3.fsf_-_@gmail.com> <8735zhyrss.fsf@gnu.org> Date: Tue, 05 Jan 2021 13:09:15 +0100 In-Reply-To: <8735zhyrss.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 04 Jan 2021 10:28:35 +0100") Message-ID: <87h7nv37ro.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org, Holger Peters X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Bonne ann=C3=A9e, Ludo! Ludovic Court=C3=A8s writes: >> From c4385abde62bba4c634a7a874c2f431451909ec2 Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D >> >> Date: Mon, 28 Dec 2020 10:36:48 +0100 >> Subject: [PATCH 1/2] gnu: smalltalk: Fix integer multiplication overflow. >> >> * gnu/packages/patches/smalltalk-multiplication-overflow.patch: Patch >> from upstream commit 72ada189aba0283c551ead16635c1983968080b8. >> * gnu/packages/smalltalk.scm (smalltalk): Use patch and link with gmp >> and lightning libraries instead of the included source. >> --- >> .../smalltalk-multiplication-overflow.patch | 121 ++++++++++++++++++ >> gnu/packages/smalltalk.scm | 43 ++++++- > > Please make sure to add the patch to =E2=80=98gnu/local.mk=E2=80=99 as we= ll. Otherwise > LGTM. Oops, I forgot about that, thank you. I've pushed with this change and some extra comments about optional packages and closure size as e3281657c8 to master. >> From 46809e6c265280571ff024c749c448c74af79c1a Mon Sep 17 00:00:00 2001 >> From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D >> >> Date: Mon, 28 Dec 2020 11:42:31 +0100 >> Subject: [PATCH 2/2] gnu: smalltalk: Update to version 3.2.91. >> >> * gnu/packages/smalltalk.scm (smalltalk): Update to 3.2.91. >> >> Co-Authored-By: Holger Peters > > LGTM. I've pushed this, together with a comment about reverting to the mirror when a new release be available, as df965a54e1 to master. > Thanks for investigating! I had it on my backlog from long time ago. Thank you for your review. :-) > We can address the non-reproducibility issues separately. Perhaps you > can send your findings to bug-guix so we can keep track of it. Sure; nonetheless, I think it will relate to two more generic issues I'm opening too. Happy hacking! Miguel