From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 05 09:30:23 2020 Received: (at 42771) by debbugs.gnu.org; 5 Dec 2020 14:30:23 +0000 Received: from localhost ([127.0.0.1]:46831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jz-WA for submit@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1klYZq-0000jY-7q for 42771@debbugs.gnu.org; Sat, 05 Dec 2020 09:30:22 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46215) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1klYZi-00061e-8J; Sat, 05 Dec 2020 09:30:16 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58398 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1klYZh-0000Jq-4I; Sat, 05 Dec 2020 09:30:13 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Holger Peters Subject: Re: bug#42771: [PATCH] Disable tests for smalltalk and add candidate releases References: <87sgcxc6lh.fsf@rohleder.de> <20201129084328.545720-1-holger.peters@posteo.de> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 15 Frimaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 05 Dec 2020 15:30:11 +0100 In-Reply-To: <20201129084328.545720-1-holger.peters@posteo.de> (Holger Peters's message of "Sun, 29 Nov 2020 09:43:28 +0100") Message-ID: <87mtys72bw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42771 Cc: 42771@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Holger, Holger Peters skribis: > * gnu/packages/smalltalk.scm (smalltalk): disable tests > (smalltalk-next): New variable. > (smalltalk-next-from-vcs): New variable. I have mostly two comments, as discussed on IRC (restating them here for those following along): 1. Instead of disabling tests wholesale, what we usually do is (1) investigate why the test is failing (I think it=E2=80=99s a single test failure here), (2) try to determine whether it=E2=80=99s serious or no= t, (3) see if we can work around it with reasonable effort, and if not, skip just this test. 2. I think we should just have =E2=80=98smalltalk=E2=80=99 (latest releas= e) and =E2=80=98smalltalk-next=E2=80=99 (VCS snapshot). Having an extra pack= age for the release candidate is not really useful IMO, and not something we generally do. HTH! Ludo=E2=80=99.