From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 07 22:27:51 2020 Received: (at 42736) by debbugs.gnu.org; 8 Aug 2020 02:27:51 +0000 Received: from localhost ([127.0.0.1]:57820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaM-0006zz-HP for submit@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4EaI-0006zj-Iv for 42736@debbugs.gnu.org; Fri, 07 Aug 2020 22:27:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39055) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4EaD-0007gF-0u; Fri, 07 Aug 2020 22:27:41 -0400 Received: from [2605:6000:1a0d:48fb::e9] (port=48148 helo=lenovo-t430) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k4EaC-0000cZ-26; Fri, 07 Aug 2020 22:27:40 -0400 From: Brett Gilio To: Jack Hill Subject: Re: [bug#42736] [PATCH] gnu: emacs-doom-themes: Update to 2.1.6-5. References: <20200807031749.27160-1-jackhill@jackhill.us> <878serjfdk.fsf@gnu.org> <87ft8y5nto.fsf@gnu.org> Date: Fri, 07 Aug 2020 21:27:58 -0500 In-Reply-To: (Jack Hill's message of "Fri, 7 Aug 2020 22:09:39 -0400 (EDT)") Message-ID: <87o8nlc1n5.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42736 Cc: 42736@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jack Hill writes: >>> On Thu, 6 Aug 2020, Brett Gilio wrote: >>> >>>> >>>> Hey Jack, >>>> >>>> Thanks for taking time to revise this package. When I originally wrote >>>> it I made notice to the fact that some elisp bytecompilations were >>>> failing or not behaving appropriately. Since then I am pretty sure >>>> hlissner has disabled the bytecompilation completely? Could you review >>>> this for me, and if true please revise the appropriate arguments. If you >>>> aren't sure what I am talking about, please let me know. > > Brett, > > I think the way forward is to follow upstream's choices and not enable > or disable byte compilation in Guix. > > After upstream introduced commit 9cd6872 [0], our trick to selectively > leave batch compilation enabled for some files didn't work because > they already had `-*- no-byte-compile: t; -*-` at the top of the > file. In my testing, I added a phase to substitute this away. Indeed, > this allowed our trick to work again. However, the material, snazzy, > and tomorrow-day themes now have problems with byte compilation. > > Therefore, I removed the disable-breaking-compilation phase > entirely. With it removed, doom-themes-autoloads.el, > doom-themes-base.el, doom-themes.el, doom-themes-ext-org.el, and > doom-themes-ext-visual-bell.el do get byte compiled. From this > evidence I concluded that upstream is aware of this issue and is only > disabling byte compilation where necessary. > > I'll send a version 2 of the patch with the phase removed shortly. > > [0] https://github.com/hlissner/emacs-doom-themes/commit/9cd6872b1af88165834230abd45743036861f925 > > Best, > Jack Jack, Thank you for investigating this issue. I agree with your solution, and I will apply your patch removing the phase. Brett