From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 03 08:44:00 2020 Received: (at 42682) by debbugs.gnu.org; 3 Aug 2020 12:44:00 +0000 Received: from localhost ([127.0.0.1]:44596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2Zou-0001uv-Fi for submit@debbugs.gnu.org; Mon, 03 Aug 2020 08:44:00 -0400 Received: from smtpo.poczta.interia.pl ([217.74.65.155]:56191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k2Zor-0001ug-Ol for 42682@debbugs.gnu.org; Mon, 03 Aug 2020 08:43:58 -0400 X-Interia-R: Interia X-Interia-R-IP: 89.64.43.25 X-Interia-R-Helo: Received: from localhost (89-64-43-25.dynamic.chello.pl [89.64.43.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Mon, 3 Aug 2020 14:43:50 +0200 (CEST) Date: Mon, 3 Aug 2020 14:43:49 +0200 From: Jan Wielkiewicz To: Mathieu Othacehe Subject: Re: [bug#42682] [PATCH 2/2] gnu: Add qmk-cli. Message-ID: <20200803144349.06022fa4@interia.pl> In-Reply-To: <87y2mwt9t0.fsf@gnu.org> References: <20200802204910.15356-1-tona_kosmicznego_smiecia@interia.pl> <20200802204910.15356-2-tona_kosmicznego_smiecia@interia.pl> <87y2mwt9t0.fsf@gnu.org> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Interia-Antivirus: OK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=interia.pl; s=biztos; t=1596458630; bh=HmiZxVxEFK9wrmOgh3Jh8MG5+r9VZN1+ejOBWVI6930=; h=X-Interia-R:X-Interia-R-IP:X-Interia-R-Helo:Date:From:To:Cc: Subject:Message-ID:In-Reply-To:References:X-Mailer:MIME-Version: Content-Type:Content-Transfer-Encoding:X-Interia-Antivirus; b=GRcbsMB6CHWO1qjlW/TlduKMWf6riKon7kf8Kagk5H1M7xTkex5yFa4qjJIgxNSmL m+71ZT+dTTdmfdmKS3zT2iROh3koloJ0AYKBOQjzOGv/xLJUi7GZaqcfUMOOLYDn1t mqWnJL2IsJ/j3yx4kxvaia207sura4M39c1ap8hU= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42682 Cc: 42682@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dnia 2020-08-03, o godz. 10:26:03 Mathieu Othacehe napisa=C5=82(a): >=20 > > + (propagated-inputs > > + `(("arm-none-eabi-gcc" ,gcc-arm-none-eabi-7-2018-q2-update) > > + ("avr-gcc" ,avr-toolchain-5) > > + ("avrdude" ,avrdude) > > + ("dfu-programmer" ,dfu-programmer) > > + ("dfu-util" ,dfu-util) > > + ("git" ,git) > > + ("python3" ,python) > > + ("python-appdirs" ,python-appdirs) > > + ("python-argcomplete" ,python-argcomplete) > > + ("python-colorama" ,python-colorama) > > + ("python-flake8" ,python-flake8) > > + ("python-hjson" ,python-hjson) > > + ("python-nose2" ,python-nose2) > > + ("python-yapf" ,python-yapf))) >=20 > Do we really need to propagate all those inputs? The python dependencies were added to propagated inputs automatically by "guix import". The other tools are needed in the user profine, because qmk-cli uses them, for example it fetches qmk firmware from git, it runs some *python stuff* and when user is done making changes to their firmware, qmk cli builds the firmware using the compiler and flashes it using dfu. I think it would be cool if Guix allowed defining profiles and environments the same way it allows defining packages. This way installing qmk-cli would also install say qmk-profile with all headers (and tools) needed for development. Now, even though arv-toolchain is installed, I have to run "guix environment qmk-cli" to be able to work with the firmware without getting build errors. > Can't we hardcode the > path to those tools directly in the sources, if they are not > registered at build time? I need them installed, so qmk-cli doesn't complain. Should the user be responsible for installing all the tools needed for development? > > + (arguments > > + `(#:phases (modify-phases %standard-phases > > + (add-before 'check 'set-qmk-home > > + (lambda _ > > + ;; tests fail without this variable set > > + (setenv "QMK_HOME" > > + "") >=20 > Who is supposed to set it otherwise? I'm not sure. That's the first thing qmk-cli sets when it is already installed. Normally, qmk-cli is installed by pip, maybe it is responsible for setting the variables? > > + "A program to help users work with QMK Firmware.") >=20 > You also need to elaborate here :) Should I describe what qmk firmware is or say more about what working with qmk firmware is, or both? > Thanks, >=20 > Mathieu