From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 07:00:28 2020 Received: (at 42380) by debbugs.gnu.org; 9 Sep 2020 11:00:28 +0000 Received: from localhost ([127.0.0.1]:57435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFxq0-0007Xo-5s for submit@debbugs.gnu.org; Wed, 09 Sep 2020 07:00:28 -0400 Received: from flashner.co.il ([178.62.234.194]:49586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFxpv-0007XV-I8 for 42380@debbugs.gnu.org; Wed, 09 Sep 2020 07:00:27 -0400 Received: from localhost (unknown [31.210.181.177]) by flashner.co.il (Postfix) with ESMTPSA id ACC9A4034D; Wed, 9 Sep 2020 11:00:17 +0000 (UTC) Date: Wed, 9 Sep 2020 13:59:44 +0300 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#42380] [PATCH] gnu: Add torbrowser-unbundle. Message-ID: <20200909105944.GQ1643@E5400> References: <20200715211547.GA17146@andel> <20200725144930.GA13751@andel> <20200803125556.GA18868@andel> <87blihhdz6.fsf@gnu.org> <20200909022429.GA24930@andel> <878sdjo1qv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZaW/dtY/7oMe/vLp" Content-Disposition: inline In-Reply-To: <878sdjo1qv.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42380 Cc: =?utf-8?B?QW5kcsOp?= Batista , 42380@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --ZaW/dtY/7oMe/vLp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 09, 2020 at 09:20:08AM +0200, Ludovic Court=C3=A8s wrote: > Hi Andr=C3=A9, >=20 > Andr=C3=A9 Batista skribis: >=20 > > Just a small token of my appreciation for your years of work on > > guix. I'm glad to be able to give something back to this community. >=20 > Thank you. >=20 > > I've been using this package for the last month or so and did not > > hit any bugs so, though I'm not a heavy web user, I think it's fair > > to say the result is functional. > > > > On the down side, the https-everywhere extension is broken as is > > since it's missing lib-wasm. I've built but did not send here a > > version which just copies lib-wasm to its proper place before > > building the extension and this version works without further > > issues. > > > > The reason I did not send it to this list is that lib-wasm source > > provides a precompiled prepackaged file[1] which is then used on > > https-everywhere build script and it's source code is not actualy > > compiled[2]. As I understand it, the Tor Project just relies on > > this precompiled binary on its build procedure and the same seems > > to be true for IceCat[3][4]. >=20 > Oh, glad that you were able to identify that issue, which presumably had > been overlooked so far. >=20 > > In order to have everything compiled from source, I've had to > > define a lot of rust libs which were required for building > > wasm-pack and then to have a rustc with wasm32-unknown-unknown > > target enabled and compatible with wasm-pack (apparently newer > > versions changed compiler strings and wasm-pack errors out when > > trying to parse). For over two weeks I've been trying without > > success and always thinking that the next build would succeed. > > > > Long story short, maybe there's just one more issue pending when > > compiling lib-wasm. When wasm-pack is invoked, everything > > compiles but I'm getting the following error: > > > > note: lld: error: /gnu/store/kwdsf42z7ib6fr5vggqi9nc4jpi1znxy-rust-1.38= =2E0/lib/rustlib/wasm32-unknown-unknown/lib/libstd-373ca16e620a2f9a.rlib: a= rchive has no index; run ranlib to add one > > > > for a few rust libs. Without lld, it complains about a missing > > rust-lld binary. Also, this appears to be the rust standard > > nowadays[5]. >=20 > Ah. I=E2=80=99m Cc=E2=80=99ing Efraim, who=E2=80=99s been very much into= Rust packaging for > some time; does that ring a bell, Efraim? >=20 It's not something that I've come across before. My first guess would be to check the linking flags against the ones icecat/firefox uses and see if anything changed. Or if it needs a different version of rust. > > If I'm not terribly wrong, this issue[6] seems to suggest an > > approach for emscripten which could solve this issue without > > removing the 'strip' phase which was the work around suggested > > by some on the same thread. > > > > Another issue that is pending is that libwasm depends on rust > > multi-default-trait-impl crate. This crate defines lgpl2.1+ on > > its Cargo.toml file, but the sources does not contain neither a > > copy of the license. So I'm unsure if this is enough to make it > > free software. So I'm planning on sending some mails to both the > > maintainer and FSF to see if this needs improvement. >=20 > Great. >=20 > >> For the final submission, we=E2=80=99d need one patch per new package,= as is > >> customary. That will have the advantage of allowing review to proceed > >> one bit at a time. :-) > > > > For sure. I'll give it a few more tries and cleanup the mess > > here before sending this patch series. If I don't succeed, I'm > > planning on sending it anyway so at least the libs can be > > added and maybe someone can spot what I'm missing. But maybe > > it's wise to hold Tor Browser itself since there has been an > > announcement of some large percentage of exit relays messing > > with Tor traffic[7]. >=20 > I don=E2=80=99t think Guix users will radically increase traffic over Tor= , so I > think we can keep going. :-) >=20 > >> Regarding Tor Browser itself, can you think of ways to factorize code > >> with IceCat? > > > > Other than sharing the https-everywhere definition, I was > > thinking maybe we could take a diff of Tor Browser and Firefox > > and avoid downloading firefox source twice when building both > > browsers. But I need to take a more careful look. I'll give > > this question some thought. >=20 > OK. I was expecting at least things like some of the build phases and > most/all of the inputs to be the same, but I haven=E2=80=99t checked. >=20 > Thanks again for all the work! >=20 > Ludo=E2=80=99. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --ZaW/dtY/7oMe/vLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAl9YtZ0ACgkQQarn3Mo9 g1G3TA/+MJXs7F3y2i5+YOi5WuWsCcpyRm1adlAYlexTjvEFm7zC5JkghHjSx8aN 6Sl6hV7K1KlV2qxT7veVsm0/+AC9XYMYqCtNpD3qbOX3H+0mo7qquZJAk9OS8axo BRgzH3AZZB3siOX/UNaJQzh/FF7MiTSMTrkhU+4lzPlGlpYiN3dcEbmUJuuNrdTp Nx7c4TStSyh8QU2OY9nA37LY2KbPgs1Wy3QmCApGNS/rI5wZ7SlnQW6OA3ASSqaj jFDU1M3vSj7WQ+GtwhRIb5MEKRzfKj3szTqgBVG45c0yZZxKzc1kPZyOxX4z0nlH xwjtJgJWfTpC+/Ubz0KHJX5R8QsCUfLgu0u1XF/MzN24XnfwN3fOxVFg8IYysS93 j3GFxgSOsj9jFf1GmJ94CsvpdRLrw4M0NId/vuNhUhMjch/YRmq826LpXNMdJ664 OLr1tgRrfAfGcaAooA46A1U+gQoSWcRKn8/Rb4MTzbfsWtrkwWabLDR61iFpWzhR JBz2gdV+VgifpsGFkkFfotLM0ivs4kTDzkMslPufVGnXNF7fJtmaJs3dYysgSH1A rYR1kxh8bzujLm+qznLwWF+uEpTphDZ0aNrZDRz5n1gXPxzsF4lS6Gb3SfU1ydFF zqavljCCAH50Z3pS6yNBwYoR9zQPiAEHpEjMgY00VKGfwWhx4yg= =om71 -----END PGP SIGNATURE----- --ZaW/dtY/7oMe/vLp--