From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 26 08:25:59 2020 Received: (at 42295) by debbugs.gnu.org; 26 Nov 2020 13:25:59 +0000 Received: from localhost ([127.0.0.1]:40168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiHHb-0000Po-7M for submit@debbugs.gnu.org; Thu, 26 Nov 2020 08:25:59 -0500 Received: from mail.ftbfs.org ([52.8.68.13]:26334 helo=aws.ftbfs.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kiHHX-0000PY-Q4 for 42295@debbugs.gnu.org; Thu, 26 Nov 2020 08:25:58 -0500 Received: from ip68-5-94-190.oc.oc.cox.net ([68.5.94.190] helo=[192.168.1.12]) by aws.ftbfs.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kiHHR-0007N7-Km; Thu, 26 Nov 2020 13:25:50 +0000 Subject: Re: [bug#42295] [PATCH] gnu: rust-1.44: Add rustfmt output. To: John Soo References: <20200709123256.7690-1-kraai@ftbfs.org> <87blfltrxp.fsf@asu.edu> From: Matthew Kraai Message-ID: <5407eb2f-b499-2520-e0e5-48ca7171e6bd@ftbfs.org> Date: Thu, 26 Nov 2020 05:25:48 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.4.0 MIME-Version: 1.0 In-Reply-To: <87blfltrxp.fsf@asu.edu> Content-Type: multipart/mixed; boundary="------------58BC27B8DB1EFCBFE6D86764" Content-Language: en-US X-Spam-Status: No (score -1.0): ALL_TRUSTED=-1 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 42295 Cc: 42295@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------58BC27B8DB1EFCBFE6D86764 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Hi John, On 11/25/20 6:46 AM, John Soo wrote: > Hi Matthew, > > Thanks! I had packaged rustfmt-nightly but this is much better. > > Matthew Kraai writes: > >> + (replace 'check >> + (lambda* _ >> + ;; Enable parallel execution. >> + (let ((parallel-job-spec >> + (string-append "-j" (number->string >> + (min 4 >> + (parallel-job-count)))))) >> + (invoke "./x.py" parallel-job-spec "test" "-vv") >> + (invoke "./x.py" parallel-job-spec "test" >> + "src/tools/cargo") >> + (invoke "./x.py" parallel-job-spec "test" >> + "src/tools/rustfmt")))) > Nice! > >> + (outputs '("out" "doc" "cargo" "rustfmt")) > Perhaps we should make anything that can be installed as a rustup > component an output (provided the source is in the rust tree). I think > rls can be added immediately in the same fashion. Is rls deprecated in favor of rust-analyzer? > Do you want to add a copyright line? Done. > Otherwise, this looks good to me. According to https://github.com/rust-lang/rustfmt, rustfmt was made a component in 1.24.0.  Would it be better to add this support to the rust-1.24 package instead?  I've attached the patch I'm currently testing. -- Matthew Kraai --------------58BC27B8DB1EFCBFE6D86764 Content-Type: text/plain; charset=UTF-8; name="patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch" ZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9ydXN0LnNjbSBiL2dudS9wYWNrYWdlcy9ydXN0 LnNjbQppbmRleCAwNTQwNGRlMWQ4Li5kN2EyNmQyZjQ2IDEwMDY0NAotLS0gYS9nbnUvcGFj a2FnZXMvcnVzdC5zY20KKysrIGIvZ251L3BhY2thZ2VzL3J1c3Quc2NtCkBAIC0xMCw2ICsx MCw3IEBACiA7OzsgQ29weXJpZ2h0IMKpIDIwMTkgSXZhbiBQZXRrb3YgPGl2YW5wcGV0a292 QGdtYWlsLmNvbT4KIDs7OyBDb3B5cmlnaHQgwqkgMjAyMCBKYWt1YiBLxIVkemlvxYJrYSA8 a3ViYUBrYWR6aW9sa2EubmV0PgogOzs7IENvcHlyaWdodCDCqSAyMDIwIFBpZXJyZSBMYW5n bG9pcyA8cGllcnJlLmxhbmdsb2lzQGdteC5jb20+Cis7OzsgQ29weXJpZ2h0IMKpIDIwMjAg TWF0dGhldyBLcmFhaSA8a3JhYWlAZnRiZnMub3JnPgogOzs7CiA7OzsgVGhpcyBmaWxlIGlz IHBhcnQgb2YgR05VIEd1aXguCiA7OzsKQEAgLTY5MCw2ICs2OTEsNyBAQCBqZW1hbGxvYyA9 IFwiIiBqZW1hbGxvYyAiL2xpYi9saWJqZW1hbGxvY19waWMuYSIgIlwiCiAgICAgICAgICAg IjF2djEweDJoOWtxN2Z4aDJ2MDFkYW1kcThwdmxwNWFjeWgxa3pjZGE5c2ZqeDEya3Y5OXki KSkpCiAgICAgKHBhY2thZ2UKICAgICAgIChpbmhlcml0IGJhc2UtcnVzdCkKKyAgICAgIChv dXRwdXRzIChjb25zICJydXN0Zm10IiAocGFja2FnZS1vdXRwdXRzIGJhc2UtcnVzdCkpKQog ICAgICAgKGFyZ3VtZW50cwogICAgICAgIChzdWJzdGl0dXRlLWtleXdvcmQtYXJndW1lbnRz IChwYWNrYWdlLWFyZ3VtZW50cyBiYXNlLXJ1c3QpCiAgICAgICAgICAoKCM6cGhhc2VzIHBo YXNlcykKQEAgLTcwMSw3ICs3MDMsMzYgQEAgamVtYWxsb2MgPSBcIiIgamVtYWxsb2MgIi9s aWIvbGliamVtYWxsb2NfcGljLmEiICJcIgogICAgICAgICAgICAgICAgICAgIDs7IFRoaXMg dGVzdCBpcyBrbm93biB0byBmYWlsIG9uIGFhcmNoNjQgYW5kIHBvd2VycGM2NGxlOgogICAg ICAgICAgICAgICAgICAgIDs7IGh0dHBzOi8vZ2l0aHViLmNvbS9ydXN0LWxhbmcvcnVzdC9p c3N1ZXMvNDU0MTAKICAgICAgICAgICAgICAgICAgICAoKCJmbiB0ZXN0X2xvYWRpbmdfY29z aW5lIikgIiNbaWdub3JlXVxuZm4gdGVzdF9sb2FkaW5nX2Nvc2luZSIpKQotICAgICAgICAg ICAgICAgICAjdCkpKSkpKSkpKQorICAgICAgICAgICAgICAgICAjdCkpCisgICAgICAgICAg ICAgKGFkZC1hZnRlciAnY29uZmlndXJlICdlbmFibGUtZXh0ZW5kZWQtYnVpbGQKKyAgICAg ICAgICAgICAgIChsYW1iZGEqIF8KKyAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJj b25maWcudG9tbCIKKyAgICAgICAgICAgICAgICAgICAoKCJbW11idWlsZFtdXSIpICJbYnVp bGRdXG5leHRlbmRlZCA9IHRydWUiKSkKKyAgICAgICAgICAgICAgICAgI3QpKQorICAgICAg ICAgICAgIChyZXBsYWNlICdidWlsZAorICAgICAgICAgICAgICAgKGxhbWJkYSogXworICAg ICAgICAgICAgICAgICAoaW52b2tlICIuL3gucHkiICJidWlsZCIpCisgICAgICAgICAgICAg ICAgIChpbnZva2UgIi4veC5weSIgImJ1aWxkIiAic3JjL3Rvb2xzL2NhcmdvIikKKyAgICAg ICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiAiYnVpbGQiICJzcmMvdG9vbHMvcnVzdGZt dCIpKSkKKyAgICAgICAgICAgICAocmVwbGFjZSAnY2hlY2sKKyAgICAgICAgICAgICAgIChs YW1iZGEqIF8KKyAgICAgICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiAiLWoxIiAidGVz dCIgIi12diIpCisgICAgICAgICAgICAgICAgIChpbnZva2UgIi4veC5weSIgIi1qMSIgInRl c3QiICJzcmMvdG9vbHMvY2FyZ28iKQorICAgICAgICAgICAgICAgICAoaW52b2tlICIuL3gu cHkiICItajEiICJ0ZXN0IiAic3JjL3Rvb2xzL3J1c3RmbXQiKQorICAgICAgICAgICAgICAg ICAjdCkpCisgICAgICAgICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAgICAgICAg IChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAg ICAgICAgICAgKGludm9rZSAiLi94LnB5IiAiaW5zdGFsbCIpCisgICAgICAgICAgICAgICAg IChzdWJzdGl0dXRlKiAiY29uZmlnLnRvbWwiCisgICAgICAgICAgICAgICAgICAgOzsgcmVw bGFjZSBwcmVmaXggdG8gc3BlY2lmaWMgb3V0cHV0CisgICAgICAgICAgICAgICAgICAgKCgi cHJlZml4ID0gXCJbXlwiXSpcIiIpCisgICAgICAgICAgICAgICAgICAgIChzdHJpbmctYXBw ZW5kICJwcmVmaXggPSBcIiIgKGFzc29jLXJlZiBvdXRwdXRzICJjYXJnbyIpICJcIiIpKSkK KyAgICAgICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiAiaW5zdGFsbCIgImNhcmdvIikK KyAgICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJjb25maWcudG9tbCIKKyAgICAgICAg ICAgICAgICAgICA7OyByZXBsYWNlIHByZWZpeCB0byBzcGVjaWZpYyBvdXRwdXQKKyAgICAg ICAgICAgICAgICAgICAoKCJwcmVmaXggPSBcIlteXCJdKlwiIikKKyAgICAgICAgICAgICAg ICAgICAgKHN0cmluZy1hcHBlbmQgInByZWZpeCA9IFwiIiAoYXNzb2MtcmVmIG91dHB1dHMg InJ1c3RmbXQiKSAiXCIiKSkpCisgICAgICAgICAgICAgICAgIChpbnZva2UgIi4veC5weSIg Imluc3RhbGwiICJydXN0Zm10IikpKSkpKSkpKSkKIAogOzs7IFJ1c3QgMS4yNSByZWxlYXNl IHN1cHBvcnQgd29yayB3aXRoIGxsdm0gNi0tYnV0IGJ1aWxkIHdpdGggbGx2bSA2IGlzCiA7 Ozsgbm90IGRldGVybWVuaXN0aWMgZHVlIHRvIDxodHRwczovL2dpdGh1Yi5jb20vcnVzdC1s YW5nL3J1c3QvaXNzdWVzLzUwNTU2Pi4KQEAgLTc2NCw2ICs3OTUsNyBAQCBqZW1hbGxvYyA9 IFwiIiBqZW1hbGxvYyAiL2xpYi9saWJqZW1hbGxvY19waWMuYSIgIlwiCiAgICAgICAgICAg YChtb2RpZnktcGhhc2VzICxwaGFzZXMKICAgICAgICAgICAgICA7OyBiaW5hcnllbiB3YXMg cmVwbGFjZWQgd2l0aCBMTEQgcHJvamVjdCBmcm9tIExMVk0KICAgICAgICAgICAgICAoZGVs ZXRlICdkb250LWJ1aWxkLW5hdGl2ZSkKKyAgICAgICAgICAgICAoZGVsZXRlICdlbmFibGUt ZXh0ZW5kZWQtYnVpbGQpCiAgICAgICAgICAgICAgKHJlcGxhY2UgJ2NoZWNrCiAgICAgICAg ICAgICAgICAobGFtYmRhKiBfCiAgICAgICAgICAgICAgICAgIDs7IEVuYWJsZSBwYXJhbGxl bCBleGVjdXRpb24uCkBAIC03NzMsNyArODA1LDkgQEAgamVtYWxsb2MgPSBcIiIgamVtYWxs b2MgIi9saWIvbGliamVtYWxsb2NfcGljLmEiICJcIgogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocGFyYWxsZWwtam9iLWNvdW50KSkpKSkp CiAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiBwYXJhbGxlbC1qb2Itc3Bl YyAidGVzdCIgIi12diIpCiAgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiBw YXJhbGxlbC1qb2Itc3BlYyAidGVzdCIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICJz cmMvdG9vbHMvY2FyZ28iKSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgInNyYy90 b29scy9jYXJnbyIpCisgICAgICAgICAgICAgICAgICAgKGludm9rZSAiLi94LnB5IiBwYXJh bGxlbC1qb2Itc3BlYyAidGVzdCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICJzcmMv dG9vbHMvcnVzdGZtdCIpKSkpCiAgICAgICAgICAgICAgKHJlcGxhY2UgJ3JlbW92ZS11bnN1 cHBvcnRlZC10ZXN0cwogICAgICAgICAgICAgICAgKGxhbWJkYSogXwogICAgICAgICAgICAg ICAgICA7OyBPdXIgbGQtd3JhcHBlciBjYW5ub3QgcHJvY2VzcyBub24tVVRGOCBieXRlcyBp biBMSUJSQVJZX1BBVEguCkBAIC04NDQsNiArODc4LDcgQEAgamVtYWxsb2MgPSBcIiIgamVt YWxsb2MgIi9saWIvbGliamVtYWxsb2NfcGljLmEiICJcIgogICAgICAgICAgICAgICAgICA7 OyBgcHJlZml4JyBkaXJlY3Rvcnkgc2hvdWxkIGV4aXN0IGJlZm9yZSBgaW5zdGFsbCcgY2Fs bAogICAgICAgICAgICAgICAgICAobWtkaXItcCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIp KQogICAgICAgICAgICAgICAgICAobWtkaXItcCAoYXNzb2MtcmVmIG91dHB1dHMgImNhcmdv IikpCisgICAgICAgICAgICAgICAgIChta2Rpci1wIChhc3NvYy1yZWYgb3V0cHV0cyAicnVz dGZtdCIpKQogICAgICAgICAgICAgICAgICAjdCkpCiAgICAgICAgICAgICAgKGFkZC1hZnRl ciAncGF0Y2gtY2FyZ28tdGVzdHMgJ2Rpc2FibGUtdGhpbmx0by10ZXN0CiAgICAgICAgICAg ICAgICAobGFtYmRhKiBfCg== --------------58BC27B8DB1EFCBFE6D86764--