From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 06 06:02:11 2020 Received: (at 42193) by debbugs.gnu.org; 6 Jul 2020 10:02:11 +0000 Received: from localhost ([127.0.0.1]:33646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsNww-0007in-V1 for submit@debbugs.gnu.org; Mon, 06 Jul 2020 06:02:11 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jsNwt-0007iI-By for 42193@debbugs.gnu.org; Mon, 06 Jul 2020 06:02:09 -0400 Received: from webmail.gandi.net (webmail19.sd4.0x35.net [10.200.201.19]) (Authenticated sender: brice@waegenei.re) by relay3-d.mail.gandi.net (Postfix) with ESMTPA id 4473360015; Mon, 6 Jul 2020 10:01:59 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 06 Jul 2020 10:01:59 +0000 From: Brice Waegeneire To: Danny Milosavljevic Subject: Re: [bug#42193] [WIP 4/6] services: kernel-module-loader: Return a single 'shepherd-service'. In-Reply-To: <20200706020322.3577052e@scratchpost.org> References: <20200704185234.12571-1-brice@waegenei.re> <20200704185431.13739-5-brice@waegenei.re> <20200706020322.3577052e@scratchpost.org> Message-ID: X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.13 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 42193 Cc: 42193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Danny, On 2020-07-06 00:03, Danny Milosavljevic wrote: > I mean technically we could do that, but almost none of the other > "-shepherd-service"s we have avoid returning a list. Why single this > one out? Because I wrote that module, forgetting to add a plural to 'kernel-module-loader-shepherd-service' and when reading the dnsmasq service code I was made aware of it. It's either that patch or a stupid typo one to go from 'kernel-module-loader-shepherd-service' to 'kernel-module-loader-shepherd-serviceS'. There are currently 14 other services that are using that pattern. > Could we change all of them to not return a list? Maybe, but I don't see the point of doing so as I expect that if the procedure's name is plural and return a list there is no need to change it. - Brice