From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 25 16:48:53 2020 Received: (at 42047) by debbugs.gnu.org; 25 Jun 2020 20:48:53 +0000 Received: from localhost ([127.0.0.1]:41313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joYnl-0001hi-F9 for submit@debbugs.gnu.org; Thu, 25 Jun 2020 16:48:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1joYnj-0001hW-TO for 42047@debbugs.gnu.org; Thu, 25 Jun 2020 16:48:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44956) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1joYne-0003GC-Jk; Thu, 25 Jun 2020 16:48:46 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59568 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1joYne-0000zl-5q; Thu, 25 Jun 2020 16:48:46 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: "Jan \(janneke\) Nieuwenhuizen" Subject: Re: bug#42047: [PATCH 3/3] guix: gc: Support for the Hurd. References: <20200625203850.25057-1-janneke@gnu.org> <20200625203850.25057-3-janneke@gnu.org> Date: Thu, 25 Jun 2020 22:48:43 +0200 In-Reply-To: <20200625203850.25057-3-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Thu, 25 Jun 2020 22:38:50 +0200") Message-ID: <87pn9mq3bo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 42047 Cc: 42047@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Jan (janneke) Nieuwenhuizen" skribis: > * guix/store/roots.scm (proc-environ-roots): Handle EIO, for the Hurd. > * gnu/build/hurd-boot.scm (set-hurd-device-translators): Mount /proc. Add > symlink to /etc/mtab. Remove duplicate calls to 'scope'. Nitpick: I see 3 mostly unrelated patches: (1) fix duplicate called to =E2=80=98scope=E2=80=99, (2) mount /proc, and (3) handle EIO. I think it= =E2=80=99s clearer to view them separately. (1) and (2) LGTM! > - (mkdir* (scope "dev/vcs/1")) > - (mkdir* (scope "dev/vcs/2")) > - (mkdir* (scope "dev/vcs/2")) Was it creating like /some/root/some/root/dev/vcs/1? > (append-map rhs-file-names > - (split-on-nul > - (call-with-input-file environ > - get-string-all)))) > + (catch 'system-error > + (lambda _ > + (split-on-nul > + (call-with-input-file environ > + get-string-all))) > + (lambda args > + (if (=3D EIO (system-error-errno args)) > + '() > + (apply throw args)))))) This may be papering over a real problem. Before doing that, I think =E2=80=9Cwe=E2=80=9D :-) should investigate why procfs returns EIO in some = cases and look into fixing it. Then maybe we can still have the =E2=80=98catch=E2=80=99 above, but this ti= me as a temporary measure and with a reference to the upstream issue/commit. WDYT? Thank you! Ludo=E2=80=99.