From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 13 09:05:34 2020 Received: (at 41785) by debbugs.gnu.org; 13 Jun 2020 13:05:34 +0000 Received: from localhost ([127.0.0.1]:41060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk5qn-0000Pr-Sy for submit@debbugs.gnu.org; Sat, 13 Jun 2020 09:05:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jk5qn-0000Pg-7L for 41785@debbugs.gnu.org; Sat, 13 Jun 2020 09:05:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56563) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jk5qg-0004pt-Nv; Sat, 13 Jun 2020 09:05:26 -0400 Received: from [2001:980:1b4f:1:42d2:832d:bb59:862] (port=34702 helo=dundal.peder.onsbrabantnet.nl) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jk5qT-0006Zj-7b; Sat, 13 Jun 2020 09:05:26 -0400 From: Jan Nieuwenhuizen To: Mathieu Othacehe Subject: Re: [bug#41785] [PATCH v3 1/2] image: Make 'find-image' non-monadic. Organization: AvatarAcademy.nl References: <20200610085441.890-1-janneke@gnu.org> <20200612214214.14112-1-janneke@gnu.org> <87r1ujjkst.fsf@gnu.org> X-Url: http://AvatarAcademy.nl Date: Sat, 13 Jun 2020 15:05:11 +0200 In-Reply-To: <87r1ujjkst.fsf@gnu.org> (Mathieu Othacehe's message of "Sat, 13 Jun 2020 12:56:50 +0200") Message-ID: <878sgrazg8.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41785 Cc: 41785@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe writes: Hey Mathieu, >> (system (current-system)) >> (target (operating-system-derivation target-os)) >> - (base-image (find-image >> - installation-disk-image-file-system= -type)) >> + (base-image -> (find-image >> + installation-disk-image-file-sys= tem-type >> + (%current-target-system))) > > This should be: > > (target (current-target-system)) > ... > (base-image -> (find-image > installation-disk-image-file-system-type > target)) Ah, right. Done and moved this >> (target (operating-system-derivation target-os)) down. >> + ((image -> (find-image file-system-type (%current-target-system)= )) >> (sys (system-derivation-for-action os image action >> #:file-system-type file= -system-type >> #:image-size image-size > > Same here, otherwise this look good to me. Thanks! Pushed to master as 7ca533c7237622d70b423033c4506217d9ce4014 (probably/hopefully soon to be revisited by your image-catalog feature :-) Greetings, Janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com