From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 03:37:12 2020 Received: (at 41756) by debbugs.gnu.org; 9 Jun 2020 07:37:12 +0000 Received: from localhost ([127.0.0.1]:58736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYop-0004CL-TO for submit@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jiYoo-0004C8-2r for 41756@debbugs.gnu.org; Tue, 09 Jun 2020 03:37:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36517) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jiYoi-00083t-Ft; Tue, 09 Jun 2020 03:37:04 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58634 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jiYoe-0006XD-QK; Tue, 09 Jun 2020 03:37:03 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Christopher Baines Subject: Re: [bug#41756] [PATCH] gnome: gnome-desktop: Add bubblewrap as an input. References: <20200607202226.15637-1-mail@cbaines.net> Date: Tue, 09 Jun 2020 09:36:59 +0200 In-Reply-To: <20200607202226.15637-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 7 Jun 2020 21:22:26 +0100") Message-ID: <87r1uoofl0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41756 Cc: 41756@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! (There=E2=80=99s a typo in the subject prefix.) Christopher Baines skribis: > This is expected to be available, oddly as libseccomp is available. These > changes fix thumbnails for Nautilus. > > * gnu/packages/gnome.scm (gnome-desktop)[arguments]: Add 'patch-bubblewrap > phase. > [inputs]: Add bubblewrap. Nice, I didn=E2=80=99t know the thumbnailer would do that. > + (add-before 'configure 'patch-bubblewrap > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "libgnome-desktop/gnome-desktop-thumbnail-scri= pt.c" > + (("\"bwrap\",") > + (string-append "\"" (which "bwrap") "\",")) > + (("\"--ro-bind\", \"/usr\", \"/usr\",") > + (string-append "\"--ro-bind\", \"" > + (%store-directory) > + "\", \"" > + (%store-directory) > + "\",")) > + (("\"--ro-bind\", \"/etc/ld.so.cache\", \"/etc/ld.so.cach= e\",") > + "\"--ro-bind\", \"/run/current-system\", \"/run/current-= system\",")) Perhaps we can replace this second --ro-bind with the empty string? Otherwise LGTM! Ludo=E2=80=99.