From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 14 18:15:50 2020 Received: (at 41753-done) by debbugs.gnu.org; 14 Jun 2020 22:15:50 +0000 Received: from localhost ([127.0.0.1]:44658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkaun-0002br-V8 for submit@debbugs.gnu.org; Sun, 14 Jun 2020 18:15:50 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:55472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkaui-0002bc-La for 41753-done@debbugs.gnu.org; Sun, 14 Jun 2020 18:15:44 -0400 Received: (qmail 21761 invoked by uid 1009); 15 Jun 2020 00:15:38 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25842. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.041089 secs); 14 Jun 2020 22:15:38 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 15 Jun 2020 00:15:38 +0200 Date: Mon, 15 Jun 2020 00:15:37 +0200 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#41753] [PATCH] gnu: Add tup. Message-ID: <20200614221537.w3d5leewtpf5e4gj@gravity> References: <20200607190711.20988-1-kuba@kadziolka.net> <87imfts6u8.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lxhjq7volznjj6hc" Content-Disposition: inline In-Reply-To: <87imfts6u8.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41753-done Cc: 41753-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --lxhjq7volznjj6hc Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 14, 2020 at 10:58:07PM +0200, Ludovic Court=C3=A8s wrote: > Hi, >=20 > Jakub K=C4=85dzio=C5=82ka skribis: >=20 > > * gnu/packages/build-tools.scm (tup): New variable. > > * gnu/packages/patches/tup-unbundle-dependencies.patch: New file. > > * gnu/local.mk (dist_patch_DATA): Register new file. >=20 > [...] >=20 > > --- /dev/null > > +++ b/gnu/packages/patches/tup-unbundle-dependencies.patch > > @@ -0,0 +1,74 @@ > > +From 895a7d4e8200f9430414a5fe47756efb67d2e5d0 Mon Sep 17 00:00:00 2001 > > +From: =3D?UTF-8?q?Jakub=3D20K=3DC4=3D85dzio=3DC5=3D82ka?=3D > > +Date: Sun, 7 Jun 2020 15:14:42 +0200 > > +Subject: [PATCH] Unbundle dependencies > > + > > +--- > > + build.sh | 10 ++++------ > > + src/tup/db.c | 2 +- > > + src/tup/tupid.h | 2 +- > > + 3 files changed, 6 insertions(+), 8 deletions(-) >=20 > Nitpick: I=E2=80=99d remove the whole Git header and just keep the subjec= t. >=20 > Otherwise LGTM! Thanks for the review! I have pushed a revised patch as commit 2c1d1b7599a3738cdbdcaa281d56fa47b0b4c025. Regards, Jakub K=C4=85dzio=C5=82ka --lxhjq7volznjj6hc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl7moYkACgkQ4xWnWEYT FWRHvg//VBqW4bUqEhmu/Of5Li/gWzyTC8YCLTQskp0/cT6AFgeS5Yk0tTag+APi elFDpleQvPKZFJXXc98lMR0vi9D5Q5g0dOBR1A+8MT+C5zN5I8uFo5Np+rm7yJAV VTW4VKaLMBPQhtZSQPoNRYeSN2kTUaaaKuRLoyJ2PbPMMTQmz/COvJEzAjims9q4 Z8Ql8QnADsidx6tv+KjuHnrFCF8h8VHDndHCdNojsODT845EqFD4uav9O/iHTYYX ESJm2kydIyycvNuPQSxJvc2etgZmKjBaZe75zHEBN5UiY5C01dzPhRpNvlKYxo2c tVEbL9OPNYjqfsmrQY9qpZdqXca0V5zsp42xfSDfOZTJCJkgfXWwhctL21vNGncC urNLz6nGuZ+R+rHwnEIOYzSdAmmR9E0b3qkv8aR+/xTjte8yOxoljbwGBAnLCPmp 8tciJJm9Js6wwCoDQjqz5zat9Jege3Lclqv32yZRabD4pftGz0wCR/dK4E+GGAQ2 kOOLQNxDlAnk0n3QQ1C6Da9urKRDxN/tUKVhW3PHKWr8CYX8N7bwhUpVSN0J5tpB wTIk/M0/bG93DYU8uuQoyuyOGDoNeFzW8AFVAG0D1xkkQhq1LBSJX8mY5D9uSAxE yCYl3KW7oBM73PgBz3xY/dhobXPlmvLi81cY4jLaccDyFoMhNjU= =uS9y -----END PGP SIGNATURE----- --lxhjq7volznjj6hc--