From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 02 17:08:51 2020 Received: (at 41671) by debbugs.gnu.org; 2 Jun 2020 21:08:52 +0000 Received: from localhost ([127.0.0.1]:41094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE9T-00049k-Ml for submit@debbugs.gnu.org; Tue, 02 Jun 2020 17:08:51 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:39761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jgE9S-00049X-8o for 41671@debbugs.gnu.org; Tue, 02 Jun 2020 17:08:50 -0400 Received: by mail-wm1-f68.google.com with SMTP id k26so4546486wmi.4 for <41671@debbugs.gnu.org>; Tue, 02 Jun 2020 14:08:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/EZqNR8XZj7oCfDIxdA9aHv1iAN/Vw+gZ0tzTMI3wTs=; b=RTfgb4rlLqy0ChlsbAs3lvKkSyIUC+Sxhy6nryMar88yiZI8eHex5khQmq9GmxyBgF aZ3EYjBEQTPw2/bSNrI9EvAWi09qn5lDAowOHNclV3TT8GrLkyf3+LuMVn+tPQOJ5PFK cpTkJoxzXoBfC2SuzmS9Idrehia5nLOEh/LFPDS2nXMGGhIhkz1EJkZx0D8OSE07y/W0 jPFxictZk+pIdzgU7Uk473BWsKebhgJfe9/IHGAEr08cYejI53+2nkFnwaEIO3Yiu6Hz /uV7W3HcJugRJSVwE+yO3h24if+Wb7upWVsPayMAwp6Qkf8m3jQ5rNMB3c9AgeK3OxdF 53iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/EZqNR8XZj7oCfDIxdA9aHv1iAN/Vw+gZ0tzTMI3wTs=; b=ms0hpWy+ZE4zg1qFLy+Clpm7yDcygFTOm44P8LTt34NBzVBYfIXueawAKmHJoBik+P DygeHqETnnWG4dKG5GUix3MiGEx/Jd+3utX2VPuGeRM9kuHlx3HGc1Hcdy95znIfWIZi C6nkBc5iPpVYu8b7FpsLcLTJPXZu5auROdQDVFgAkKD6LOF3p0X8giR1iVSiax3UKlWQ p/1n9cr6Gixiwv5DGb+aoLz6nq8cZMK7n9YLPxrIJz6uT2S2LedAHlYMfjT3aJXSN4wb /iJPP4fUrp9s5ZaNMxKknCUcHEY7jQQ5z4GjNaLBjJvAE9w5adtwx3hWt6dndPN3C3vz J42A== X-Gm-Message-State: AOAM531mOAxUYJlx07oZQW4jePH4iFe1DlTfKphuAT8QfxG8KPnaqCaE kZRyIVBuxuAvmL21EZ+z/lShX/jb7WHSihaZgac= X-Google-Smtp-Source: ABdhPJwzKLnpbfox0sDSvuGdrnejZzyMSdaeH3qDajNPZfOqhBl91IvDtoFs7yMoi6RVDtbbnTkdOdqVsXjYedjkTGM= X-Received: by 2002:a1c:7e43:: with SMTP id z64mr5526717wmc.72.1591132124302; Tue, 02 Jun 2020 14:08:44 -0700 (PDT) MIME-Version: 1.0 References: <20200602194137.30412-1-plattfot@gmail.com> <878sh5dykv.fsf@nicolasgoaziou.fr> In-Reply-To: <878sh5dykv.fsf@nicolasgoaziou.fr> From: Fredrik Salomonsson Date: Tue, 2 Jun 2020 14:08:33 -0700 Message-ID: Subject: Re: [bug#41671] [PATCH] gnu: Add emacs-glsl-mode To: Nicolas Goaziou Content-Type: multipart/alternative; boundary="0000000000000f50c005a7205126" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41671 Cc: 41671@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000f50c005a7205126 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Nicolas, Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou = : > Nitpick: you need full stops at the end of each sentence in the commit > message. > > > + (sha256 > > + (base32 > > + "0bav9ipfm0vy26n74ngsmjzc7fsyqz6xmriadzx55s44h8p5dn1s")))) > > Nitpick: could you move the hash on the same line as `base32'? > > > + (build-system emacs-build-system) > > + (home-page > > + "https://github.com/jimhourihan/glsl-mode") > > Nitpick: could you move the URL on the same line as `home-page'? > > > + (synopsis > > + "Major mode for Open GLSL shader files") > > Nitpick: =E2=80=A6 guess what=E2=80=A6 ;) > > > + (description > > + "Major mode for editing OpenGLSL grammar files, usually files > ending with > > +`.vert', `.frag', `.glsl', `.geom'. > > This should be a complete sentence, e.g., > > The library provides a major mode=E2=80=A6 > > Note that Texinfo syntax for file extensions is @file, so the rest of > the sentence ought to be: > > files ending with @file{.vert}, @file{.frag}=E2=80=A6 > > > Is is based on c-mode plus some > > Typo and nitpick: "It is based on C mode" > > Could you send an updated patch? > Thank you for the speedy response. I sent in a new patch, which should fix all the things mentioned above. Let me know if it ended up in the right place. I'm pretty new with the git send-email workflow. --=20 s/Fred[re]+i[ck]+/Fredrik/g --0000000000000f50c005a7205126 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Nicolas,

Den tis 2 juni 2020 kl 13:04 skrev Nicolas Goaziou= <mail@nicol= asgoaziou.fr>:
Nitpick: you need full stops at the end of each sentence in the commit
message.

> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(sha256
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (base32
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"0bav9ipfm0vy26n74ngsmj= zc7fsyqz6xmriadzx55s44h8p5dn1s"))))

Nitpick: could you move the hash on the same line as `base32'?

> +=C2=A0 =C2=A0 =C2=A0 (build-system emacs-build-system)
> +=C2=A0 =C2=A0 =C2=A0 (home-page
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"https://github.com/ji= mhourihan/glsl-mode")

Nitpick: could you move the URL on the same line as `home-page'?

> +=C2=A0 =C2=A0 =C2=A0 (synopsis
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"Major mode for Open GLSL shader file= s")

Nitpick: =E2=80=A6 guess what=E2=80=A6 ;)

> +=C2=A0 =C2=A0 =C2=A0 (description
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0"Major mode for editing OpenGLSL gram= mar files, usually files ending with
> +`.vert', `.frag', `.glsl', `.geom'.

This should be a complete sentence, e.g.,

=C2=A0 The library provides a major mode=E2=80=A6

Note that Texinfo syntax for file extensions is @file, so the rest of
the sentence ought to be:

=C2=A0 files ending with @file{.vert}, @file{.frag}=E2=80=A6

> Is is based on c-mode plus some

Typo and nitpick: "It is based on C mode"

Could you send an updated patch?
Thank you for the speedy response. I sent in a new patch, whic= h should fix all the things mentioned above.
Let me know if it en= ded up in the right place. I'm pretty new with the git send-email workf= low.=C2=A0

--
s/Fred[re]+i[ck]+/Fredrik/g
--0000000000000f50c005a7205126--