From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 10:27:32 2020 Received: (at 41594-done) by debbugs.gnu.org; 30 May 2020 14:27:32 +0000 Received: from localhost ([127.0.0.1]:58856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2SS-0003El-0J for submit@debbugs.gnu.org; Sat, 30 May 2020 10:27:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2SQ-0003EZ-3i for 41594-done@debbugs.gnu.org; Sat, 30 May 2020 10:27:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35734) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf2SK-00027D-Bb; Sat, 30 May 2020 10:27:24 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:42850 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jf2SH-0006sG-RS; Sat, 30 May 2020 10:27:23 -0400 From: Marius Bakke To: Josh Holland , 41594-done@debbugs.gnu.org Subject: Re: [bug#41594] [PATCH] gnu: bemenu: Update to 0.4.1. In-Reply-To: <20200529091439.388824-1-josh@inv.alid.pw> References: <20200529091439.388824-1-josh@inv.alid.pw> Date: Sat, 30 May 2020 16:27:19 +0200 Message-ID: <87ftbhzeew.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41594-done Cc: Josh Holland X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Josh Holland writes: > * gnu/packages/xdisorg.scm (bemenu): Update to 0.4.1. Applied, thanks! > --- > I'm not 100% sure that the CFLAGS setting is correct, but without > -fPIC the build fails. Upstream changed their build system, and now > we do not need to explicitly enable the Wayland backend. This is because lib/3rdparty/cdl.a is built statically, and needs to be embedded into the shared libbemenu.so.0. It's odd that the Makefile does not add -fPIC for us though, can you file an upstream bug? Ideally we'd build cdl separately as a shared library and provide it as an input, then -fPIC would be unnecessary. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SbUcACgkQoqBt8qM6 VPr4Ygf/ScRACH01Q87JgM1V0ZxcM6g/4CywoF0SSc8VJkKp5B926A5B8EvehJ/f VWPJqnmRD/sy03M9rmI8UfFJwWoI2AkAG1wm+9AIQoVEQ4bc+r1X53TCcEsNM+bm I79KpQjpXNwKm/mfZfzgo3A4UDlAIC2Fwh7Ui3f5bCr9YuwtjxzsHnYLIN+CQO6b AAwq93kR913Y9XHo3yBoWQWiioKm6QasO+P5XH0E36zJEd7ShNzHzvZaNCbJnEGC bzqUiWzo4+RvVis3QT4XutEP1jMa1e/2cNBEuZVCENcQQd7wlSF6Ve+5r/a1bGot Pkb8myMM8OGhBNMiBCgKWFxLKMYdhQ== =keHW -----END PGP SIGNATURE----- --=-=-=--