From debbugs-submit-bounces@debbugs.gnu.org Mon May 25 03:37:28 2020 Received: (at 41507) by debbugs.gnu.org; 25 May 2020 07:37:29 +0000 Received: from localhost ([127.0.0.1]:39649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7fs-0001db-K5 for submit@debbugs.gnu.org; Mon, 25 May 2020 03:37:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jd7fq-0001dM-U9 for 41507@debbugs.gnu.org; Mon, 25 May 2020 03:37:27 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45133) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jd7fk-0003J1-8k; Mon, 25 May 2020 03:37:20 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=50162 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jd7fj-0001tM-PO; Mon, 25 May 2020 03:37:20 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Jelle Licht Subject: Re: [bug#41507] [PATCH Shepherd 0/2] Use 'signalfd' on GNU/Linux References: <20200524142700.6151-1-ludo@gnu.org> <87o8qd2wos.fsf@jlicht.xyz> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 May 2020 09:37:18 +0200 In-Reply-To: <87o8qd2wos.fsf@jlicht.xyz> (Jelle Licht's message of "Sun, 24 May 2020 17:13:07 +0200") Message-ID: <87tv04wjm9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41507 Cc: 41507@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Jelle, Jelle Licht skribis: > I am extremely happy to see that you got this to work; I bashed my head > against a wall getting the signal-handling thread to block the right > signals. This does seem like something that should be in guile proper > rather than shepherd though. Oh right, you had first-hand experience fiddling with this! Yeah ideally Guile would provide some =E2=80=98signalfd=E2=80=99 support. = I=E2=80=99m not sure exactly how that should work. It=E2=80=99s easier to have ad-hoc support i= n the Shepherd in the meantime. > As I read it, you need to set up a signalfd handlers for specific > signals before ever calling `sigaction'. Does this not have an impact on > being able to do some forms of REPL-driven development with shepherd? It depends, I don=E2=80=99t test things like SIGCHLD handling from the REPL anyway. :-) > Perhaps it makes sense to document this gotcha (and some of its > implications) in a location other than an inline comment in > `maybe-signal-port'. Where would you document that? Currently, one gets a warning if signals cannot be properly blocked. Thanks for your feedback! Ludo=E2=80=99.