From debbugs-submit-bounces@debbugs.gnu.org Sat May 30 08:04:36 2020 Received: (at 41455) by debbugs.gnu.org; 30 May 2020 12:04:36 +0000 Received: from localhost ([127.0.0.1]:57044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0E8-0007k8-C6 for submit@debbugs.gnu.org; Sat, 30 May 2020 08:04:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf0E6-0007jv-KZ for 41455@debbugs.gnu.org; Sat, 30 May 2020 08:04:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33379) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf0E0-0005N2-Vy; Sat, 30 May 2020 08:04:29 -0400 Received: from ti0006q161-2604.bb.online.no ([84.202.68.75]:56012 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jf0E0-00047M-GY; Sat, 30 May 2020 08:04:28 -0400 From: Marius Bakke To: Edouard Klein , 41455@debbugs.gnu.org Subject: Re: [bug#41455] [PATCH 2/2] gnu: Add python-daemux In-Reply-To: <87d06rysxi.fsf@alice.lan> References: <87d06wazez.fsf@alice.lan> <87v9kkick4.fsf@alice.lan> <87mu5v63b1.fsf@gnu.org> <87d06rysxi.fsf@alice.lan> Date: Sat, 30 May 2020 14:04:25 +0200 Message-ID: <87d06l39yu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41455 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Edouard Klein writes: >>> + (file-name (git-file-name name version)) >>> + (sha256 >>> + (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph")))) >>> + (build-system python-build-system) >>> + (arguments >>> + `(#:phases (modify-phases %standard-phases >>> + (replace 'check >>> + (lambda _ >>> + (mkdir-p "tmptmux") >>> + (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux")) >>> + (invoke "tmux" "new-session" "-d") >>> + (invoke "make" "test")))))) >> >> Nice! I guess 'tmux' needs to be a native-input if we don't propagate >> it from libtmux. >> > > I'm not sure what you mean. tmux is indeed a propagated input of > python-libtmux, which is in turn a propagated input of python-daemux. Do > you mean that it should be added explicitly here instead of being > implicit ? Yes, because in another review I recommended against propagating tmux. The reason is that I (and presumably others) sometimes add custom patches to my local packages. If the vanilla tmux is propagated, I would not be able to use python-daemux with my installed patched tmux. Does that make sense? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7SS8kACgkQoqBt8qM6 VPo4swf8CBIsJqyo8rYuJXqPWnatqD7qfafekYxa1ZIvYO7TAB39eBRTEJ6hWb6C EPrYDEFTRC0ojJxhi+WflfOMWI66UqScFbB1i2wS2fE/yBdMxalWBhMSDfxRDLDP cOQs4nOFOD1p8PBVnkKFYuZtCku8kSGkiUj3fKt+JXAF9nZIi79wWo/jLDyfaTUZ i7HRmrJfH1dWwiDGHx4sTxluJztn/BZlYCk3kaVwK3x2/DcDQA9Ou/t43+st8bqg EepnD4hytMm8wKI1e7018Ml1g6PYxjxRLBmyOiVfWP+9nIl/Rks0CBOO+uOuMzTb GnEYItG8lr6Ff1tzOQZa2mrwD7A3/Q== =YVmE -----END PGP SIGNATURE----- --=-=-=--