From debbugs-submit-bounces@debbugs.gnu.org Tue May 26 09:01:07 2020 Received: (at 41455) by debbugs.gnu.org; 26 May 2020 13:01:07 +0000 Received: from localhost ([127.0.0.1]:44392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdZCa-0007qp-KV for submit@debbugs.gnu.org; Tue, 26 May 2020 09:01:07 -0400 Received: from sender4-op-o11.zoho.com ([136.143.188.11]:17125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdVPO-00088v-Nn for 41455@debbugs.gnu.org; Tue, 26 May 2020 04:58:03 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1590483480; cv=none; d=zohomail.com; s=zohoarc; b=hmhc0BE6UvdBt5BwKH0YZtmLne62nR7JMizuYGGi/cE4vkh+g5Fgstkn/qXPplA2JvM5QhkuOaF3twNpIr3fFxKcyt6Ny9UH7plwasiLXkmQiwVCOk2WOOUbzoagkw2xyl41K05ErPjD1hVJC+sQjpxbe1E8RwuT01VwB8YPGaA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1590483480; h=Content-Type:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=JTUT/6vMFAii5scq8Q8zRSJUz6ayj/MFRuZTGmbTzEE=; b=fM82Nixq8HBolQlsFP7dtKTJkXx/rlSt6WYDRXd2i6ZQqEoyEzCh4fEQJjrMmxlE2RdsvzX7yCDVfHI8RvAXv1HHI3aqRFaB0UqNknWIjx2VjpxgdD4hWIHxTK/oWt5Uf1EuVxlox4jc0HYpv5iQ2X/jYWV+QpTNdkgTpeyvNxM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=rdklein.fr; spf=pass smtp.mailfrom=edou@rdklein.fr; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1590483480; s=zoho; d=rdklein.fr; i=edou@rdklein.fr; h=References:From:To:Subject:In-reply-to:Message-ID:Date:MIME-Version:Content-Type; bh=JTUT/6vMFAii5scq8Q8zRSJUz6ayj/MFRuZTGmbTzEE=; b=JKnmjnV8CM7whL0KPBx8Zh4IiWS8r3BpSzN7kjTaD/zjvy1+VFuFvH+aBzVxOxeA Y+NOv3kD4oRxE7CVoxjCnel2/U3x/qDfehaG8vKWGJ/SQ465+n8VF1n4NvYw+zSPFGJ VjMcQJe+vP6982OHs4jwUH9h39IowteHoICTNlZw= Received: from alice.lan (lfbn-idf1-1-1299-119.w90-79.abo.wanadoo.fr [90.79.23.119]) by mx.zohomail.com with SMTPS id 1590483476074476.51489733395056; Tue, 26 May 2020 01:57:56 -0700 (PDT) References: <87d06wazez.fsf@alice.lan> <87v9kkick4.fsf@alice.lan> <87mu5v63b1.fsf@gnu.org> User-agent: mu4e 1.4.6; emacs 26.3 From: Edouard Klein To: 41455@debbugs.gnu.org Subject: Re: [bug#41455] [PATCH 2/2] gnu: Add python-daemux In-reply-to: <87mu5v63b1.fsf@gnu.org> Message-ID: <87d06rysxi.fsf@alice.lan> Date: Tue, 26 May 2020 10:57:45 +0200 MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 41455 X-Mailman-Approved-At: Tue, 26 May 2020 09:01:03 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Marius Bakke writes: > Edouard Klein writes: > >> * gnu/packages/tmux.scm (python-daemux): New variable. > > [...] > >> +(define-public python-daemux >> + (package >> + (name "python-daemux") >> + (version "0.1.0") >> + (source >> + ;; We fetch from the Git repo because there are no tests in the PyPI >> + ;; archive. >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/edouardklein/daemux.git") >> + (commit "58e30331d3cce08655cb5f55e94396568d484f9a"))) > > This upstream looks familiar... Do you think upstream is willing to tag > a 0.1.0 release instead of using a "magic" commit identifier? :-) > Of course :) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + (replace 'check >> + (lambda _ >> + (mkdir-p "tmptmux") >> + (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux")) >> + (invoke "tmux" "new-session" "-d") >> + (invoke "make" "test")))))) > > Nice! I guess 'tmux' needs to be a native-input if we don't propagate > it from libtmux. > I'm not sure what you mean. tmux is indeed a propagated input of python-libtmux, which is in turn a propagated input of python-daemux. Do you mean that it should be added explicitly here instead of being implicit ? >> + (propagated-inputs >> + `(("python-libtmux" ,python-libtmux))) >> + (native-inputs >> + `(("python-coverage" ,python-coverage) >> + ("python-sphinx" ,python-sphinx))) >> + (home-page "https://github.com/edouardklein/daemux") >> + (synopsis >> + "Start, stop, restart and check daemons via tmux") > > This line break is unnecessary. > > Otherwise LGTM, thanks! Cool ! Thank you for reviewing.