Marius Bakke writes: > Edouard Klein writes: > >> * gnu/packages/tmux.scm (python-daemux): New variable. > > [...] > >> +(define-public python-daemux >> + (package >> + (name "python-daemux") >> + (version "0.1.0") >> + (source >> + ;; We fetch from the Git repo because there are no tests in the PyPI >> + ;; archive. >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://github.com/edouardklein/daemux.git") >> + (commit "58e30331d3cce08655cb5f55e94396568d484f9a"))) > > This upstream looks familiar... Do you think upstream is willing to tag > a 0.1.0 release instead of using a "magic" commit identifier? :-) > Of course :) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 "0cb8v552f2hkwz6d3hwsmrz3gd28jikga3lcc3r1zlw8ra7804ph")))) >> + (build-system python-build-system) >> + (arguments >> + `(#:phases (modify-phases %standard-phases >> + (replace 'check >> + (lambda _ >> + (mkdir-p "tmptmux") >> + (setenv "TMUX_TMPDIR" (string-append (getcwd) "/tmptmux")) >> + (invoke "tmux" "new-session" "-d") >> + (invoke "make" "test")))))) > > Nice! I guess 'tmux' needs to be a native-input if we don't propagate > it from libtmux. > I'm not sure what you mean. tmux is indeed a propagated input of python-libtmux, which is in turn a propagated input of python-daemux. Do you mean that it should be added explicitly here instead of being implicit ? >> + (propagated-inputs >> + `(("python-libtmux" ,python-libtmux))) >> + (native-inputs >> + `(("python-coverage" ,python-coverage) >> + ("python-sphinx" ,python-sphinx))) >> + (home-page "https://github.com/edouardklein/daemux") >> + (synopsis >> + "Start, stop, restart and check daemons via tmux") > > This line break is unnecessary. > > Otherwise LGTM, thanks! Cool ! Thank you for reviewing.