From debbugs-submit-bounces@debbugs.gnu.org Sat May 23 10:18:04 2020 Received: (at 41431) by debbugs.gnu.org; 23 May 2020 14:18:04 +0000 Received: from localhost ([127.0.0.1]:35245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUyR-0001ic-QY for submit@debbugs.gnu.org; Sat, 23 May 2020 10:18:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUyQ-0001hs-OT for 41431@debbugs.gnu.org; Sat, 23 May 2020 10:18:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43620) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUyL-0006hq-DD; Sat, 23 May 2020 10:17:57 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52286 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcUyB-0008NH-Vi; Sat, 23 May 2020 10:17:55 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ryan Prior Subject: Re: [bug#41431] [PATCH] gnu: Add protonvpn-cli. References: <20200521032943.26115-1-rprior@protonmail.com> Date: Sat, 23 May 2020 16:17:46 +0200 In-Reply-To: <20200521032943.26115-1-rprior@protonmail.com> (Ryan Prior's message of "Thu, 21 May 2020 03:29:46 +0000") Message-ID: <87o8qe68hh.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41431 Cc: 41431@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ryan Prior skribis: > * gnu/packages/vpn.scm (protonvpn-cli): New variable. Overall LGTM, with minor issues: > + (arguments '(#:tests? #f)) When enabling the tests, I get: --8<---------------cut here---------------start------------->8--- starting phase `check' running "python setup.py" with command "test" and parameters () running test running egg_info writing protonvpn_cli.egg-info/PKG-INFO writing dependency_links to protonvpn_cli.egg-info/dependency_links.txt writing entry points to protonvpn_cli.egg-info/entry_points.txt writing requirements to protonvpn_cli.egg-info/requires.txt writing top-level names to protonvpn_cli.egg-info/top_level.txt reading manifest file 'protonvpn_cli.egg-info/SOURCES.txt' writing manifest file 'protonvpn_cli.egg-info/SOURCES.txt' running build_ext error: [Errno 13] Permission denied: '/.pvpn-cli' command "python" "-c" "import setuptools, tokenize;__file__=3D'setup.py';f= =3Dgetattr(tokenize, 'open', open)(__file__);code=3Df.read().replace('\\r\\= n', '\\n');f.close();exec(compile(code, __file__, 'exec'))" "test" failed w= ith status 1 --8<---------------cut here---------------end--------------->8--- So there are definitely tests, but for some reason they=E2=80=99re not work= ing as expected. Could you take a look? (In general we don=E2=80=99t disable = tests unless there=E2=80=99s a compelling reason to do so.) > + (description > + "ProtonVPN is a secure point-to-point virtual private networking se= rvice > +with a gratis tier.") > + (home-page "https://github.com/ProtonVPN/linux-cli") > + (license license:gpl3))) This is =E2=80=98gpl3+=E2=80=99 AFAICS since nothing says =E2=80=9Cversion = 3 only.=E2=80=9D Could you send an updated patch? Bonus points if you expound the description a bit. :-) Thanks, Ludo=E2=80=99.