From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 09 02:15:40 2022 Received: (at 41360) by debbugs.gnu.org; 9 Sep 2022 06:15:40 +0000 Received: from localhost ([127.0.0.1]:60737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWXIh-0003cd-TO for submit@debbugs.gnu.org; Fri, 09 Sep 2022 02:15:40 -0400 Received: from mail-wr1-f52.google.com ([209.85.221.52]:46740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWXId-0003cO-K6 for 41360@debbugs.gnu.org; Fri, 09 Sep 2022 02:15:38 -0400 Received: by mail-wr1-f52.google.com with SMTP id e20so968528wri.13 for <41360@debbugs.gnu.org>; Thu, 08 Sep 2022 23:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:references:message-id:in-reply-to :thread-topic:subject:from:date:mime-version:from:to:cc:subject:date; bh=6VDbw+KM3OL0N2KUQ1bAO19tu6VyugGTzwUHC5Sp9iU=; b=EjSV8xe8RSvjlL5NI07VNX/GrV0KL/ki94JbbKfwhccWIWM1vRktsx08W6el4fPQPi 92TOwqLpbJM2HvrC5HAvp9g7BgVmdQqCA+bN8pwz6Xfiyp1PUGl8BVPitbTieybvtNjd mos3muLVu0dVcdR6d71idf3+1uMiey7KOMWstOcrxFrUMkBHnc5J8v01+h6dIYdcQ/WG UrroLy3v6HfWNT3CH5vmaL360H0IMQqfP/REZ5nIvgHUh37pKJWnWVY19xwkgmWv5TQr QU5cO0o7F23mALANWbFqVzktHAIo3BcsZdiAzQkBxMZUnGV9AVPwlsI2OLrzvge9rlr7 HiXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:references:message-id:in-reply-to :thread-topic:subject:from:date:mime-version:x-gm-message-state:from :to:cc:subject:date; bh=6VDbw+KM3OL0N2KUQ1bAO19tu6VyugGTzwUHC5Sp9iU=; b=dU1UJuqZZPUU5cUCGQ17X9MFlqcaAkae9gfH1fH/B/G8QzLGQThaxJc5iOp79zRN7q GPznGN5X1IUEZlRWmr75YJjIwFpAukMIPypRwmARGtOn+h/Cv7ZDvxmTCqAbn2Myu3gT wrADp6Hh1o/VKOMutw3O4n++zx0hU1A0XQD/e2/1iqRs7aON2prgSYOs9PLeC4hFQenr wCBaNGT5DrFtIL2mBPaO4ane6dDK5cupzKGD64voFXzRU7KkeGxUVRnjyX91uHxaV6Cf 9Bge/qjUE0/DYE3hugSwGYI0yxIrRQcit2eeTaqW40yCvGRWWZAy+bfInuhELqxx/Wdh RL7Q== X-Gm-Message-State: ACgBeo180gGj921bu2Rvq40aFgrW0nD4/xeWZj8utgp2B9gky1dMY9rR 8YztBcWgrz5cpCxzx0Zeb5w= X-Google-Smtp-Source: AA6agR60gvTK+2lHVhZxBS3prPNbar340ZdgB3EzpU1M0yuvKHIHx+rH9AmoQN6i3D3KwR4XXZYzJw== X-Received: by 2002:a5d:44cf:0:b0:228:dc26:eb3c with SMTP id z15-20020a5d44cf000000b00228dc26eb3cmr7046705wrr.389.1662704129532; Thu, 08 Sep 2022 23:15:29 -0700 (PDT) Received: from EXO ([2a01:4b00:883d:f900:3c09:b752:785b:a7e6]) by smtp.gmail.com with ESMTPSA id f2-20020a5d6642000000b0022a34a2e091sm1040964wrw.22.2022.09.08.23.15.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Sep 2022 23:15:29 -0700 (PDT) MIME-Version: 1.0 Date: Fri, 9 Sep 2022 07:15:29 +0100 From: Ioannis Subject: RE: [PATCH v5] finalize java-openjfx packages Thread-Topic: RE: [PATCH v5] finalize java-openjfx packages In-Reply-To: Message-ID: <061B18E4-27E1-4DCC-A064-843C31A6F5F7@hxcore.ol> References: <20220621192706.39031ffd@sybil.lepiller.eu>, To: Julien Lepiller Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8" X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 41360 Cc: "41360@debbugs.gnu.org" <41360@debbugs.gnu.org>, "ludo@gnu.org" , "levenson@mmer.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/)

Hi Ju= lien,

 

Any= chance you could have a look at the patches?

=  

Thanks

&n= bsp;

From: Ioannis Kappas
Sent: 26 June 2022 08:22
To= : Julien Lepiller
Cc: <= /b>41360@debbugs.gnu.org; levenson@mmer.org; ludo@gnu.org
Subject: Re: [PATCH v5] finalize ja= va-openjfx packages

 

Hi Julien,

 

On Tue, Jun 21, 2022 at 6:27 PM Julien Lepiller <juli= en@lepiller.eu> wrote:

> 

=

> Hi Ioannis,

>&nbs= p;

> Could you fix all this and send a new= patch series, with one patch per

> package, so = we can try applying them and checking them more closely?

 

please find patch v6 series= as attached. Changes from last patch are

&nbs= p;

1. Each package definition is in a separat= e commit/patch file - as requested.

1. Output all n= ative libs to lib/openjfx - no arch specific directory,

as requested.

2. Add native libs path to java.= library.path property at static initialization,

so = that the NativeLibsLoader can locate them at runtime=C2=A0 - This is a

<= p class=3DMsoNormal>better working solution than loading by absolute path, = since the

latter was not working during testing if = the native libs were not

installed.

3. Install native libs after 'install phase - previously the nativ= e

libs were installed unconditionally just after co= mpilation, which is

wrong.

= 4. Pass CMAKE_CXX_FLAGS argument as a single string - as requested.

5. Use new style inputs for packages - as requested.

6. Remove #t at the end of phases - as requested.

 

Thanks

 

=