From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 14:14:24 2022 Received: (at 41360) by debbugs.gnu.org; 21 Jun 2022 18:14:24 +0000 Received: from localhost ([127.0.0.1]:33244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3iOO-0006yG-7W for submit@debbugs.gnu.org; Tue, 21 Jun 2022 14:14:24 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:41483) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o3iON-0006y5-5f for 41360@debbugs.gnu.org; Tue, 21 Jun 2022 14:14:23 -0400 Received: by mail-wr1-f46.google.com with SMTP id q9so20066991wrd.8 for <41360@debbugs.gnu.org>; Tue, 21 Jun 2022 11:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5E1PU+iBuDUiNhmPKIB8DXiDgsNL857BGVqAh0VWSsk=; b=IGqbh23M9o3HAPo22IBIsK1YysLC/itvV37tJInWmpjzcGvGBLF9LTsf8Uk6ujvn8S V9dCxs3O+6INk0YeL2SilERZkhBjORMn2ks3NuZExceW720Rh2xGkgwTNvK++OLPSUpH tLVV72Ncow1AGLxg+uT6wpGZdIVj+Rh2m+yg12uVzClh8H+VMc1zEwA2FK/jffk/WIe3 jlWsqzonFDczoNVlcFQUIpTHxF5QSjW7qK4STUubhXEoFVSFNvF7k2f3Sngh3+d3CUx2 IdjtdljgWpBMGhiD4GU4DcGcxa17V5U/0dPuHPUS9S5MXHE67Ls/+BzDxslQS2BLVCRC qdjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5E1PU+iBuDUiNhmPKIB8DXiDgsNL857BGVqAh0VWSsk=; b=j7XLYHBsMMtTEVdBhDSPzij98f9Y3ZyqEnBRnhKu/gARMV0+EtyKETAudCn9JxsUs5 FjZJnByHn0focwWSRoxGgj+4ydwak7v+23YVWDu6HnSK5fmcVtx/hxSKOr0aTe76aUoU SznNqjdGDN+Pvhpg0hysI/FFK2BHZVrhoGh99LQ1DbruAkBSHp5dzF8rua9d7oT6n4Tj j4TDOht8t7GlbUIQJkoSUxjEU6cvI3esjHcjYwJOcc2Osr8zywzZMYHFjLTyTKlsKHMZ QSqTEljGLYuy2mZy+ys8vpoK2H9hchH9hL7W/Jr/875aXb14kOnyUUIsUGYnKNhhAoc8 kXsg== X-Gm-Message-State: AJIora/M+D0eLtUxqKaQLkw++uSEh8tRnfRRtnW7Fr8FEkb9+U4f9Vdu kNrBQqRZU9hGJqe+W32xHpZOBQ8FaxCZMKlbPYI= X-Google-Smtp-Source: AGRyM1v5zlQMS5gLzYT2yWEG5lfHmMbklN4wUmmCpeQTQwDOwjGl3LC7JLzawatfgUzbsT/F9OoOfh5bXyVMk2YhXrw= X-Received: by 2002:adf:d22b:0:b0:21b:90be:2dc8 with SMTP id k11-20020adfd22b000000b0021b90be2dc8mr10596018wrh.423.1655835257298; Tue, 21 Jun 2022 11:14:17 -0700 (PDT) MIME-Version: 1.0 References: <20220621192706.39031ffd@sybil.lepiller.eu> In-Reply-To: <20220621192706.39031ffd@sybil.lepiller.eu> From: Ioannis Kappas Date: Tue, 21 Jun 2022 19:14:05 +0100 Message-ID: Subject: Re: [PATCH v5] finalize java-openjfx packages To: Julien Lepiller Content-Type: multipart/mixed; boundary="0000000000005179e405e1f93051" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 41360 Cc: 41360@debbugs.gnu.org, ludo@gnu.org, levenson@mmer.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000005179e405e1f93051 Content-Type: text/plain; charset="UTF-8" On Tue, Jun 21, 2022 at 6:27 PM Julien Lepiller wrote: > > Hi Ioannis, > > So, I read only patches 2 and 3. In the third patch, I have a couple > suggestions, in addition to what I told you in my previous message. > > java-openjfx-build-web-js-test.patch doesn't seem to be present in the > patch. My apologies, attached as 0004. (Alexey, it would be great if you can check if the patches solve the davmail issues you've mentioned) > > > 2. Output native libs to openjfx standard share/amd64 dir. > > That would only work on x86_64-linux I think. Could you either install > to some common directory, and then fix loading, or to a directory that > depends on the architecture, so it can find the libraries on other > architectures too? Sure will have a look. There are also some examples in java.scm that utilize %current-system and/or %current-target-system that I was thinking of using, but couldn't find any documentation to point me which one is the correct one. > We could get rid of all the #t at the end of phases, it's deprecated > now. > > Could you fix all this and send a new patch series, with one patch per > package, so we can try applying them and checking them more closely? Will do, and also try to address the comments from the previous email. Happy to get this through as many iterations as necessary. Thanks --0000000000005179e405e1f93051 Content-Type: application/octet-stream; name="0004-Include-missing-java-openjfx-build-web-js-test.patch.patch" Content-Disposition: attachment; filename="0004-Include-missing-java-openjfx-build-web-js-test.patch.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l4oh6ac20 RnJvbSA2MzRmOTZhYjJiMGUwMGU5ZDNkZTg1Y2VjYzY0MTJlOGI2MDc5NWU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJb2FubmlzIEthcHBhcyA8aW9hbm5pcy5rYXBwYXNAZ21hbWls LmNvbT4KRGF0ZTogVHVlLCAyMSBKdW4gMjAyMiAxMDoyOTozNCArMDEwMApTdWJqZWN0OiBbUEFU Q0ggdjUgNC80XSBJbmNsdWRlIG1pc3NpbmcgamF2YS1vcGVuamZ4LWJ1aWxkLXdlYi1qcy10ZXN0 LnBhdGNoCiBmaWxlCgotLS0KIC4uLi9qYXZhLW9wZW5qZngtYnVpbGQtd2ViLWpzLXRlc3QucGF0 Y2ggICAgICAgfCAxOCArKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNl cnRpb25zKCspCiBjcmVhdGUgbW9kZSAxMDA2NDQgZ251L3BhY2thZ2VzL3BhdGNoZXMvamF2YS1v cGVuamZ4LWJ1aWxkLXdlYi1qcy10ZXN0LnBhdGNoCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2Vz L3BhdGNoZXMvamF2YS1vcGVuamZ4LWJ1aWxkLXdlYi1qcy10ZXN0LnBhdGNoIGIvZ251L3BhY2th Z2VzL3BhdGNoZXMvamF2YS1vcGVuamZ4LWJ1aWxkLXdlYi1qcy10ZXN0LnBhdGNoCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLjA0MDA0Mjk3NmEKLS0tIC9kZXYvbnVsbAor KysgYi9nbnUvcGFja2FnZXMvcGF0Y2hlcy9qYXZhLW9wZW5qZngtYnVpbGQtd2ViLWpzLXRlc3Qu cGF0Y2gKQEAgLTAsMCArMSwxOCBAQAorRml4IHRlc3QgZnJvbSBsYXRlciByZXZpc2lvbgorCity ZXBvcnQ6IGh0dHBzOi8vYnVncy5vcGVuamRrLm9yZy9icm93c2UvSkRLLTgyMTIwMTQKKworZml4 OiBodHRwOi8vaGcub3Blbmpkay5qYXZhLm5ldC9vcGVuamZ4Lzh1LWRldi9ydC9yZXYvNjk3YTEz OGMzYjZiCisKK2RpZmYgLS1naXQgYS9tb2R1bGVzL3dlYi9zcmMvdGVzdC9qYXZhL2phdmFmeC9z Y2VuZS93ZWIvSmF2YVNjcmlwdEJyaWRnZVRlc3QuamF2YSBiL21vZHVsZXMvd2ViL3NyYy90ZXN0 L2phdmEvamF2YWZ4L3NjZW5lL3dlYi9KYXZhU2NyaXB0QnJpZGdlVGVzdC5qYXZhCistLS0gYS9t b2R1bGVzL3dlYi9zcmMvdGVzdC9qYXZhL2phdmFmeC9zY2VuZS93ZWIvSmF2YVNjcmlwdEJyaWRn ZVRlc3QuamF2YQorKysrIGIvbW9kdWxlcy93ZWIvc3JjL3Rlc3QvamF2YS9qYXZhZngvc2NlbmUv d2ViL0phdmFTY3JpcHRCcmlkZ2VUZXN0LmphdmEKK0BAIC01NzgsNyArNTc4LDcgQEAKKyAgICAg ICAgICAgICBiaW5kKCJhbGlzdCIsIGFsaXN0KTsKKyAgICAgICAgICAgICBJbnRlZ2VyW10gaWFy ciA9IG5ldyBJbnRlZ2VyWzRdOworICAgICAgICAgICAgIGJpbmQoImlhcnIiLCBpYXJyKTsKKy0g ICAgICAgICAgICBPYmplY3QgciA9IHdlYi5leGVjdXRlU2NyaXB0KCJhbGlzdC50b0FycmF5KGlh cnIpIik7CisrICAgICAgICAgICAgT2JqZWN0IHIgPSB3ZWIuZXhlY3V0ZVNjcmlwdCgiYWxpc3Rb J3RvQXJyYXkoT2JqZWN0W10pJ10oaWFycikiKTsKKyAgICAgICAgICAgICBhc3NlcnRTYW1lKGlh cnIsIHIpOworICAgICAgICAgICAgIGFzc2VydEVxdWFscygiOTgvODcvNzYvbnVsbCIsCisgICAg ICAgICAgICAgICAgICAgICAgICAgIGlhcnJbMF0rIi8iK2lhcnJbMV0rIi8iK2lhcnJbMl0rIi8i K2lhcnJbM10pOwotLSAKMi4zNC4wCgo= --0000000000005179e405e1f93051--