From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 22 15:17:07 2020 Received: (at 41293) by debbugs.gnu.org; 22 Jun 2020 19:17:07 +0000 Received: from localhost ([127.0.0.1]:34560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRwJ-0007yG-1e for submit@debbugs.gnu.org; Mon, 22 Jun 2020 15:17:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnRwF-0007xR-6E for 41293@debbugs.gnu.org; Mon, 22 Jun 2020 15:17:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47339) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnRw9-0006VZ-ID; Mon, 22 Jun 2020 15:16:57 -0400 Received: from ti0006q161-3115.bb.online.no ([88.95.106.80]:56460 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jnRw8-0003i5-T8; Mon, 22 Jun 2020 15:16:57 -0400 From: Marius Bakke To: Ryan Prior , Ryan Prior via Guix-patches , 41293@debbugs.gnu.org Subject: Re: [bug#41293] [PATCH 1/3] gnu: Add sideload. In-Reply-To: <20200602012736.4292-2-rprior@protonmail.com> References: <20200602012736.4292-1-rprior@protonmail.com> <20200602012736.4292-2-rprior@protonmail.com> Date: Mon, 22 Jun 2020 21:16:54 +0200 Message-ID: <87d05qdi6x.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41293 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello! Sorry for the slooow response... Ryan Prior via Guix-patches via writes: > * gnu/packages/pantheon.scm (sideload): New variable. [...] > + (modify-phases %standard-phases > + (add-before 'install 'set-environment-variables > + (lambda _ > + ;; Disable compiling schemas and updating desktop databases > + (setenv "DESTDIR" "/") > + #t)) That's an unorthodox workaround :-) does the build system ignore it when DESTDIR is set, or do they just end up in a different location? Is the "glib:bin" input still needed? > + (inputs > + `(("flatpak" ,flatpak) > + ("granite" ,granite) > + ("gtk" ,gtk+) > + ("libostree" ,libostree))) > + (propagated-inputs > + `(("glib-networking" ,glib-networking))) Can you add a comment about why this needs to be propagated? > + (native-inputs > + `(("cmake" ,cmake) Use 'cmake-minimal' if CMake is required (is it?). > + ("gettext" ,gettext-minimal) > + ("glib" ,glib) > + ("glib:bin" ,glib "bin") > + ("gobject-introspection" ,gobject-introspection) > + ("libgee" ,libgee) > + ("libxml2" ,libxml2) > + ("pkg-config" ,pkg-config) > + ("vala" ,vala))) > + (home-page "https://github.com/elementary/sideload") > + (synopsis "Graphical application to side-load Flatpaks") > + (description "Sideload handles flatpakref files, like those you might find > +on Flathub or another third-party website providing a Flatpak app for > +download.") > + (license license:gpl3))) This should be 'gpl3+' because no source files say "GPL 3 only" (in fact they explicitly mention GPL 3 or any later version). --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl7xA6YACgkQoqBt8qM6 VPrhWQf/UsAxZQXcowqSxjaRSrPlnwnUUnWymTp2+aC0mih13Rsg41LLwHbSho7g 9+HUDbz79GJdDoi+1WOH16cOz2gsrqKZi1Hh/J0Y9xvpw8VRjp36mFSAeW840U3Z u8jMpJkxsiysnB49ZKqav4iLD8jTZvW8rDz4jaeJBt0VQ5Vs0UI0HrT9eUubBY69 FlmNrFh4d2SCsriLr9kEHu2rxlfjWaFq0banTmXXQtljBv1CkfzDPHI+E3cjpaPp J0C2BFoIhjkNLa1vmcDolor/bvwFbRzysEZMLLGBFOYtsCCtvFGSv0nf/xizx2vD GAetdnss5VXwfHolk/kIrqLz7aBMoA== =84iI -----END PGP SIGNATURE----- --=-=-=--