Subject: Re: [bug#41230] [PATCH] gnu: Add libqglviewer.

From: Kei <[email-masked]>
Date: Wed, 13 May 2020 17:05:30 -0400

On Wed, 2020-05-13 at 21:52 +0200, Ricardo Wurmus wrote:
> Kei Kebreau <[email-masked]> writes:
> 
> > * gnu/packages/qt.scm (libqglviewer): New variable.
> 
> Looks good to me!
> 
> > +    (arguments
> > +     '(#:tests? #f                      ; no check target
> > +       #:make-flags (list (string-append "PREFIX="
> > +                                         (assoc-ref %outputs
> > "out")))
> 
> Except for the formatting here.  I’d break the line before “(list”.
> 

Done and pushed to master as commit e792dd3244.  Thanks for the review!