From debbugs-submit-bounces@debbugs.gnu.org Tue May 26 17:56:34 2020 Received: (at 41174) by debbugs.gnu.org; 26 May 2020 21:56:34 +0000 Received: from localhost ([127.0.0.1]:46817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdhYk-0006RT-2y for submit@debbugs.gnu.org; Tue, 26 May 2020 17:56:34 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:53570) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jdhYe-0006RF-EP for 41174@debbugs.gnu.org; Tue, 26 May 2020 17:56:29 -0400 Received: from nijino.local (194-96-185-81.hdsl.highway.telekom.at [194.96.185.81]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 49Wnpr2ZxGz1LWny; Tue, 26 May 2020 23:56:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 49Wnpr2ZxGz1LWny DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1590530180; bh=SECvJs6WmC9c2zRBuk7CHHwSO9BOqLEXHAX/teyT1Z8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RUojeDdOis8onSzilWEOFcvfAbPQ/eVjT/62XNWMRfNl4upLsABYF/Dz+CvGj/it/ hF69hpXI3fN47q+q4RHU9z8m2BsieEu5nGlLXN1P8SG5zdLTLpMT5ghbfkWJ7IFywd 0Wbpe845805+JKPRqOvIPbYDU3Unu3fpA/zl6Ax8= Message-ID: <1b9e299efed71d54ee14fbe904647553864bdc73.camel@student.tugraz.at> Subject: Re: bug#41174: [PATCH] gnu: webkitgtk: Add patch to share all fonts. From: Leo Prikler To: Jack Hill Date: Tue, 26 May 2020 23:56:18 +0200 In-Reply-To: References: <20200526181345.32726-1-leo.prikler@student.tugraz.at> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41174 Cc: 41174@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Am Dienstag, den 26.05.2020, 15:47 -0400 schrieb Jack Hill: > On Tue, 26 May 2020, Leo Prikler wrote: > > > * gnu/packages/patches/webkitgtk-bind-all-fonts.patch: New file. > > * gnu/packages/webkit.scm (webkitgtk)[source]: Use it > > here. > > * gnu/local.mk: Add it here. > > --- > > gnu/local.mk | 1 + > > .../patches/webkitgtk-bind-all-fonts.patch | 37 > > +++++++++++++++++++ > > gnu/packages/webkit.scm | 3 +- > > 3 files changed, 40 insertions(+), 1 deletion(-) > > create mode 100644 gnu/packages/patches/webkitgtk-bind-all- > > fonts.patch > > Hi, > > I tested this patch on my local system, and it seems to resolve the > issue > for me. Thanks! > > Is this something that should be submitted for inclusion in WebKit > upstream? > > Best, > Jack Hi, I don't see anything in the patch itself, that is specific to Guix, so it should probably work upstream as well. This issue is likely going to affect other functional package managers like Nix too, so it would be nice, if we can get the patch to be accepted upstream. However, it does add a specific exception just for fonts, while other resources are still taken from XDG_DATA_HOME. As such, it is still rather an ad-hoc solution to a very specific annoyance than something "general". I'm also not quite sure, whether this could cause problems with the number of arguments being passed to the bwrap process exceeding some limit. It has not yet come up so far, but I thought I'd mention it. However, if it does, we're going to be the first to notice with our huge environment variables, so that's probably a bigger deal here than elsewhere. Regards, Leo