From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 04 06:34:57 2020 Received: (at 41143) by debbugs.gnu.org; 4 Oct 2020 10:34:57 +0000 Received: from localhost ([127.0.0.1]:45007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP1M0-0005jJ-S6 for submit@debbugs.gnu.org; Sun, 04 Oct 2020 06:34:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kP1Lz-0005j7-Je for 41143@debbugs.gnu.org; Sun, 04 Oct 2020 06:34:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39882) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kP1Lu-0000Ls-BF; Sun, 04 Oct 2020 06:34:50 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46170 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kP1Ls-0000Yn-UZ; Sun, 04 Oct 2020 06:34:49 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mikhail Tsykalov Subject: Re: [PATCH v2 2/2] mapped-devices: Add 'lvm-device-mapping'. References: <87pn69j09o.fsf@gnu.org> <20201001224900.28989-1-tsymsh@gmail.com> <20201001224900.28989-2-tsymsh@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 13 =?utf-8?Q?Vend=C3=A9miaire?= an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 04 Oct 2020 12:34:47 +0200 In-Reply-To: <20201001224900.28989-2-tsymsh@gmail.com> (Mikhail Tsykalov's message of "Fri, 2 Oct 2020 01:49:00 +0300") Message-ID: <87y2kme0u0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 41143 Cc: 41143@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mikhail Tsykalov skribis: > * gnu/system/mapped-devices.scm (lvm-device-mapping, open-lvm-device, > close-lvm-device): New variables. > > * gnu/tests/install.scm (%lvm-separate-home-os, > %lvm-separate-home-os-source, %lvm-separate-home-installation-script, > %test-lvm-separate-home-os): New variables. > > * gnu/system/linux-initrd.scm (raw-initrd): Add (srfi srfi-1) to initrd e= xpression. Nice! > +++ b/gnu/system/linux-initrd.scm > @@ -217,6 +217,7 @@ upon error." > (gnu system file-systems) > ((guix build utils) #:hide (delete)) > (guix build bournish) ;add the 'bournish' meta-c= ommand > + (srfi srfi-1) Maybe add a comment saying this is for =E2=80=98lvm-device-mapping=E2=80=99. > +(define %test-lvm-separate-home-os > + (system-test > + (name "lvm-separate-home-os") > + (description > + "Test functionality of an OS installed with a LVM /home partition") Great. Do you know what it would take to have a LVM on root? (As future work, of course.) Could you document =E2=80=98lvm-device-mapping=E2=80=99 under =E2=80=9CMapp= ed Devices=E2=80=9D in doc/guix.texi? Essentially adding a @defvr for =E2=80=98lvm-device-mapping= =E2=80=99 and a paragraph with an example. There=E2=80=99s also a sentence somewhere in guix.texi that says LVM is not supported, we can probably remove it. :-) Last: you can add an entry in etc/news.scm to mention LVM support since that=E2=80=99s a long awaited feature! Thanks! Ludo=E2=80=99.