Jean-Baptiste Note writes: > Hi Marius, > > Thanks for your review and the heads up on the correct file. > Please find an updated patch. > > I've used guix-devel-mode and ran indent-according-to-mode on the buffer > before producing the patch; let me know if this is not sufficient to > correctly indent the code :) Thanks! My Emacs agrees, so LGTM. [...] > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (delete 'configure)) > + #:make-flags (list "CC=gcc" (string-append "PREFIX=" (assoc-ref %outputs "out"))) I moved the second flag to its own line as 89 characters is a bit much. > + #:tests? #f)) And added a comment about why tests are disabled. > + (synopsis "Generate (pseudo-)random passwords and hashes") > + (description > + "Makepasswd is a program that generates pseudo-random passwords of a > +desired length. It can also generate their corresponding hashes for a given > +encryption algorithm if so desired.") > + (home-page "https://github.com/khorben/makepasswd") > + (license license:gpl3)))) Indeed GPL3 only :-/ Applied!