From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 09 09:44:09 2020 Received: (at 41011) by debbugs.gnu.org; 9 Jun 2020 13:44:10 +0000 Received: from localhost ([127.0.0.1]:59319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jieXx-0000r4-Lt for submit@debbugs.gnu.org; Tue, 09 Jun 2020 09:44:09 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:54230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jieXw-0000qw-3c for 41011@debbugs.gnu.org; Tue, 09 Jun 2020 09:44:08 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id 543DB3360C41; Tue, 9 Jun 2020 15:44:06 +0200 (CEST) Date: Tue, 9 Jun 2020 15:44:00 +0200 From: Danny Milosavljevic To: Stefan , Maxim Cournoyer , 41011@debbugs.gnu.org Subject: Re: [bug#41011] [PATCH] gnu: grub: Support for network boot via tftp/nfs. Message-ID: <20200609154400.4c7d2f90@scratchpost.org> In-Reply-To: <46CD97B3-9994-4AB7-AA7D-4DE39AB7A238@vodafonemail.de> References: <9AAFEFF4-8ACE-4C95-975F-67C3F4FDAF81@vodafonemail.de> <87a72gi4kz.fsf@gmail.com> <1179D890-7D6C-43D8-A286-DA7A0F61D585@vodafonemail.de> <87h7w7cc55.fsf@gnu.org> <92DB8E2B-1CA2-41AE-9265-53C4F5337686@vodafonemail.de> <20200606193721.1e126131@scratchpost.org> <46CD97B3-9994-4AB7-AA7D-4DE39AB7A238@vodafonemail.de> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/VxRwEO7N=R4ZOGmZunm7bnt"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 41011 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/VxRwEO7N=R4ZOGmZunm7bnt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Stefan, On Tue, 9 Jun 2020 14:16:18 +0200 Stefan wrote: > I made your requested change (using ), but when trying a 'guix= system reconfigure =E2=80=A6' I only get this error: >=20 > guix system: error: #: invalid G-expre= ssion input >=20 > There is no backtrace, no nothing. I can=E2=80=99t figure out, which part= of the code tries to read this serialisation. Do you have a clue? I think it's a problem in the transfer of the record from host side to build side, in this case mostly via Linux kernel command line arguments, which are strings. The host side code can use these records, but eventually the build side code has to get a string and reconstruct it. I don't know how to debug it except for running the translation in my head. The error reporting facility could be improved a lot :( gnu/build/linux-boot.scm is build side. It runs when the system boots. In there it has=20 (define (device-string->file-system-device device-string) ;; The "--root=3DSPEC" kernel command-line option always provides a ;; string, but the string can represent a device, a UUID, a ;; label or a NFS spec. So check for all three. (cond ((string-prefix? "/" device-string) device-string) ((uuid device-string) =3D> identity) (else (file-system-label device-string)))) But looking at the condition (uuid device-string) I have no idea what that = means, or is bound to! It was introduced by: commit 281d80d8e547fe663aaacb3226119166dd3100f9 Author: Maxim Cournoyer Date: Tue Feb 11 14:00:06 2020 -0500 linux-boot: Refactor boot-system. =20 The --root option can now be omitted, and inferred from the root file s= ystem declaration instead. =20 * gnu/build/file-systems.scm (canonicalize-device-spec): Extend to supp= ort NFS directly, and... * gnu/build/linux-boot.scm (boot-system): ...remove NFS special casing = from here. Remove nested definitions for root-fs-type, root-fs-flags and root-fs-options, and bind those inside the let* instead. Make "--root"= take precedence over the device field string representation of the root file system. * doc/guix.texi (Initial RAM Disk): Document that "--root" can be left unspecified. If "--root" is not specified, it should then pick up the root from the root file system declaration.=20 @Maxim: How can we use your commit to boot from NFS? I see no way to leave "--root" off in the first place for a regular user. (Stefan's patch adds support for network boot via tftp/nfs via grub efi net)=20 Cheers, Danny --Sig_/VxRwEO7N=R4ZOGmZunm7bnt Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl7fkiAACgkQ5xo1VCww uqX71gf/a8PRw3iuSmnX/aC9ieouLHa9StvvcwSHYIR/9fFzpklaMG/r+vQ2JPt8 2qV1HU09f9AQpVIlrUI7WjDD2Y4ydhtwmOxlYA3vz8kdAUoPpyAgI7tKxAW3pKGK xiM/qLdQvenu385e7iNT0DylZrAC01OoeQ7FPfsDaHIgNGsyWVdZ9aa49jdTtK+f B4swxxauqg0JzxrAemluNisnIMB65v9/1pTbQ1WIv/PtYEqx/VU5uqlsidO9B0B0 SmaUxG9DY6Cz1kK1cApVJtNQ4DDa923fZsuOHD+bYZEY2qhdYJM+KNzdkvZAQEnO 0I68udFPk5eox6zJ4nhUXXAQZJ+BqQ== =U3/C -----END PGP SIGNATURE----- --Sig_/VxRwEO7N=R4ZOGmZunm7bnt--