From debbugs-submit-bounces@debbugs.gnu.org Mon May 04 16:17:38 2020 Received: (at 40996) by debbugs.gnu.org; 4 May 2020 20:17:38 +0000 Received: from localhost ([127.0.0.1]:34068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVhWy-00060T-Ln for submit@debbugs.gnu.org; Mon, 04 May 2020 16:17:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVhWt-00060C-Tg for 40996@debbugs.gnu.org; Mon, 04 May 2020 16:17:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39973) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVhWo-0006JG-NH; Mon, 04 May 2020 16:17:26 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=54788 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jVhWo-0007nE-B1; Mon, 04 May 2020 16:17:26 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Brice Waegeneire Subject: Re: [bug#40996] [PATCH 3/3] gnu: usbguard: Fix warning about 'catch'. References: <20200501130930.5888-1-brice@waegenei.re> <20200501130930.5888-3-brice@waegenei.re> Date: Mon, 04 May 2020 22:17:24 +0200 In-Reply-To: <20200501130930.5888-3-brice@waegenei.re> (Brice Waegeneire's message of "Fri, 1 May 2020 15:09:30 +0200") Message-ID: <87pnbjpi97.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 40996 Cc: 40996@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Brice Waegeneire skribis: > * gnu/packages/hardware.scm (usgbuard)[source]: Get it from git. > [arguments]: Rename phase 'patch-makefile' to 'patch-build-scripts', > adjust it for the source from git and fix 'catch' path. > [native-inputs]: Add 'libtool'. [...] > (source (origin > - (method url-fetch) > - (uri (string-append > - "https://github.com/USBGuard/usbguard/releases/downl= oad/usbguard-" > - version "/usbguard-" version ".tar.gz")) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 "0gzhs8s4aka86mkcjib36z54si939ki4bmk46p6v8kln1fix= ad3j")))) > + (method git-fetch) In this particular case, perhaps you can keep using the tarball, and then= =E2=80=A6 [...] > + (delete-file "autogen.sh") ; Want network access > + (substitute* "configure.ac" > + (("/usr/include/catch") > + (string-append (assoc-ref inputs "catch") "/include"))) =E2=80=A6 modify =E2=80=98configure=E2=80=99 directly, since it=E2=80=99s a= simple and unambiguous change. That avoids the extra autotools dependencies (actually Autoconf and Automake were unnecessary before, no?). Anyway, one way or another, it=E2=80=99s a worthy change, so go for it! Ludo=E2=80=99.