From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 10 11:44:43 2020 Received: (at 40993) by debbugs.gnu.org; 10 Jun 2020 15:44:43 +0000 Received: from localhost ([127.0.0.1]:35137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2uA-0001lP-SA for submit@debbugs.gnu.org; Wed, 10 Jun 2020 11:44:43 -0400 Received: from mail-wm1-f41.google.com ([209.85.128.41]:56081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj2u8-0001lB-Fj for 40993@debbugs.gnu.org; Wed, 10 Jun 2020 11:44:41 -0400 Received: by mail-wm1-f41.google.com with SMTP id c71so2258170wmd.5 for <40993@debbugs.gnu.org>; Wed, 10 Jun 2020 08:44:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=nRMFeP048dGFaEQxN0zV6JW68ekM8Mouj3bbgJ/3UDQ=; b=PWp7L3M83l6WHjMGXcLASmOOZDuy8EFHUq+3qIOI8FyCSDBqxcFKdyj267KKd/SzN6 ufPlB5bsVLYuZSSGawj/6Po70NFN1/PV+xj6vLy2UN82XuWm9kDCAFSIMHdwYVkLdbhq YcUf68q5kJPbYARqowdu5AGkbym04Fc9YtCztR/c019NeH3vy7hcnjtZPL2Aymkw3160 ee8d6c4BcT+jiIM+7Bz4SoWm9bDKDsFnhUF+GzOsZuosPBU8YGgAQ2tfJUk2kf8M3mSn N9KdnMnyjkWOyBhX7JPLOa5XrMiDmoQRoWtjzWhVn008A/8zEd5gae4OoMzNoGosnfYS e3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=nRMFeP048dGFaEQxN0zV6JW68ekM8Mouj3bbgJ/3UDQ=; b=tpdJ5dvJRLfSShmfHE0qKG2f4BupygUuWummfNVgCitN4zXBOrKKdmfkEkTNAxfkwd QWs7XTXWHSVGHf5Fe5fETfDYEqGasY+fNCpJ3AV1XuwmlDtg0pFXWpWNMnYWS7/3OC/m b3wAVLmgCL7FdwNcX8B1MTN6nxFE7SeOZbDtg+DhA7we2yo9SgFJtDyYiO0IkKE0u1Nt u2874gor53GeFH5gn+rSPu/AZySaqywQGHyR/vOuRNfkwtBudGDlSejUvWW1q6S5qPGl oO4mUO29HUYUJJGaqUh8x1EBU/J3PFOg/5i8ErMyJdpxeWss5/7YterJqNGDi5zPPRiD Vbew== X-Gm-Message-State: AOAM530gSnEvonClS/b8fLVpQ4LbRNnFKmRdoaKqjXHSZRr6Dy4WCQQC 4cm2y6TcvX9h+y1cDrqpP3Xjqh9a1yg= X-Google-Smtp-Source: ABdhPJxwska1CxjaefUNDtA4NwCBaKZJBtH9b3sbO1CDtevsZb9F9rj/qHbGmwUEPft8sOPyxccuxA== X-Received: by 2002:a1c:a74d:: with SMTP id q74mr3788906wme.177.1591803871139; Wed, 10 Jun 2020 08:44:31 -0700 (PDT) Received: from meru (lfbn-ann-1-136-86.w86-200.abo.wanadoo.fr. [86.200.104.86]) by smtp.gmail.com with ESMTPSA id b14sm153229wmb.20.2020.06.10.08.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 08:44:30 -0700 (PDT) From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#40993] cuirass: Add build products download support. References: <87ees4uja7.fsf@gmail.com> <875zc7ki9g.fsf@gnu.org> Date: Wed, 10 Jun 2020 17:44:29 +0200 In-Reply-To: <875zc7ki9g.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 03 Jun 2020 22:26:51 +0200") Message-ID: <87h7vjlyci.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 40993 Cc: 40993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hola! > For the record, in Hydra, build products would be found if there=E2=80=99= s a > special =E2=80=98nix-support/hydra-build-products=E2=80=99 file in the ou= tput. The > advantage is that it=E2=80=99s more flexible, but the downside is that yo= u=E2=80=99d > have to adjust your derivations specifically for that. Yes, I first hesitated to replicate this mechanism but finally opted for the implemented one. I didn't like so much the idea of adding and extra, CI-specific file, to the output of some jobs. > Use =E2=80=98for-each=E2=80=99 if it=E2=80=99s for effects, as seems to b= e the case. Oh you keep repeating that to me, and I keep doing the same mistake! > Regarding #:sha256-hash: there=E2=80=99s a somewhat standard format to re= present > hashes and their algorithms as strings, but I forgot the name. Like, > you=E2=80=99d write =E2=80=9Csha256-=E2=80=9D followed by a base64 string= , something like that. > > Perhaps it=E2=80=99d be wiser to use it rather than hard-code sha256? Yes sure, I changed the database field to "checksum" so that we can use the string representation you're talking about. > Also, we don=E2=80=99t really have tests for the web UI, I don=E2=80=99t = know how much > work it=E2=80=99d be to add tests. If a more web-aware hacker could propose something, it would be great indeed :) > Apart from that, I have little to say, other than the fact that it=E2=80= =99s > really cool. :-) Thanks for reviewing! I just pushed those two commits and updated the Cuirass package. Now I'll see with Marius or Ricardo how to update Berlin, I guess. Thanks, Mathieu