From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 06:09:22 2020 Received: (at 40993) by debbugs.gnu.org; 1 May 2020 10:09:22 +0000 Received: from localhost ([127.0.0.1]:48271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUSbi-0008Dx-E2 for submit@debbugs.gnu.org; Fri, 01 May 2020 06:09:22 -0400 Received: from dd26836.kasserver.com ([85.13.145.193]:36446) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUSbh-0008Dp-Cw for 40993@debbugs.gnu.org; Fri, 01 May 2020 06:09:21 -0400 Received: from localhost (80-110-127-207.cgn.dynamic.surfer.at [80.110.127.207]) by dd26836.kasserver.com (Postfix) with ESMTPSA id CE81633616E0; Fri, 1 May 2020 12:09:19 +0200 (CEST) Date: Fri, 1 May 2020 12:09:14 +0200 From: Danny Milosavljevic To: Mathieu Othacehe Subject: Re: [bug#40993] cuirass: Add build products download support. Message-ID: <20200501120914.606ffe02@scratchpost.org> In-Reply-To: <87ees4uja7.fsf@gmail.com> References: <87ees4uja7.fsf@gmail.com> X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/Hq4UQoKH2mNRxuI0uCwnvFX"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40993 Cc: ludo@gnu.org, 40993@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Sig_/Hq4UQoKH2mNRxuI0uCwnvFX Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Mathieu, very cool! Though I agree using sendfile would be much better, especially since the us= er can download 800 MB image files there. The guile (web server) module allows passing a procedure as the #:body, but then it makes a bytevector out of the result and hard-codes the content-typ= e :P. Eventually (web server http) http-write is reached, which only supports enc= oding bytevectors and #f, that's it. No files. So we'd have to overwrite http-write. But we are using our own (web server fiberized) impl already. So our impl chould be extended to be able to get and process FDs. client-loop there has (lambda (response body) (write-response response client) (when body (put-bytevector client body)) which means the "when body" part should be extended to also handle files, n= ot just bytevectors. --Sig_/Hq4UQoKH2mNRxuI0uCwnvFX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEds7GsXJ0tGXALbPZ5xo1VCwwuqUFAl6r9UoACgkQ5xo1VCww uqV0Ygf7BNjc81KkTQWXt1QmYRHfzdoPbd+ejt9vYvY4GNmF8IgKMZkPcZoHxPDH Us3I1WRknemIK0hDngXqaRaq6UBaPUQ1TntES0CcmGmpe3CK3UZCEqlgIVwXCIOI GIzgJm7y1zLaTNc7SiL0lSzbOSGtBSyunyQVFchpqKdBNTVgDiYcbhSHNrNSqPxq /+OCuRv1gHM8MGBZFQpUJh4ehQp2O/JXAgyJD2DGKDdHFIR15rn/Voel6DQTLdiJ //vPJWAu/BNhOeNuvvSm/ZagbRnCAfLRQBp2E6Vyu7UO72gIXYwSMn/IwIQyZW+W 76TLr3lzKkVl/KwVFKav2qzbZADFRA== =AN9j -----END PGP SIGNATURE----- --Sig_/Hq4UQoKH2mNRxuI0uCwnvFX--