From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 10:18:28 2020 Received: (at 40931) by debbugs.gnu.org; 2 May 2020 14:18:28 +0000 Received: from localhost ([127.0.0.1]:53565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyK-00009O-CM for submit@debbugs.gnu.org; Sat, 02 May 2020 10:18:28 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:55529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUsyI-00009B-2B for 40931@debbugs.gnu.org; Sat, 02 May 2020 10:18:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 2E7AD2BA; Sat, 2 May 2020 10:18:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 02 May 2020 10:18:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:cc:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=QPxaukRvVQjrOtOh3dQT3129JX H4FCkk2CwT5BziZ58=; b=kkMYDhN936zXXMaMzMazpst4ObyT701hS1h0njoZPq 4+e3djnrNKAqZFfNFLqXhA8Z7ZOzZo7KY1GcqVy4PWB2kQE+Uinc73LurI1eypg8 /+eGBGGOjbK+HywJ+9DOZHFEc3xb8U6OhMPmAeQVM7L0MFCC3byng0gew38G90LI fsfqBZNzq8UDGog6XhETwtK6seaa/s1Q8ijebnoRXTNRBy6xz8t1Ag1YqXhbPJKE /EcFg/NrRXerum2YbciBzRgr8cag0i0ITpBsku5gJt2wqioeWc4QADh2TRKQYyMz Hcy9ixkevlOKJocLKUCOtqSiMm++mWPbp8sQN8A83sgg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QPxauk RvVQjrOtOh3dQT3129JXH4FCkk2CwT5BziZ58=; b=dVMkofEYIOPYjCoM2CORqY Ra7GgrzEjofT19FnUdxVbKLxaEHyiznuNfcQT84pgSTFBCBwL9Ghn3W9oguaQ5Sd HIhE3JnxyphOhG9hhD/ICge2o0Mo7PWJfDhmxg/oPzl1rAqwWPVl/FHIO6kZYUEb jdU1GU6WgemJpMjtbcwj5ZDfZeFJEBqVH3/0pTcP8RQSSneQ7rYETPOdlrpLJGws 9A7avtla7PjW976sICBP3pCmB+7h/007ffZApHQF0K5hPgjBvwrNP0HZtLXBHPxH ufio+0/VTejFvnd27kZnwNy2RxHUfUSS1YfV2oVLeJ9F6u8ypLGQE8+dhum1qqDQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufgjfhgffffkgggtsehgtderre dtredtnecuhfhrohhmpeforghrihhushcuuegrkhhkvgcuoehmsggrkhhkvgesfhgrshht mhgrihhlrdgtohhmqeenucggtffrrghtthgvrhhnpeejkeefkeelgeevjeetheeljeeute duueelvdffvedufeevtddvfeevieefheevtdenucffohhmrghinhepghhithhhuhgsrdgt ohhmnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 26C193065F95; Sat, 2 May 2020 10:18:19 -0400 (EDT) From: Marius Bakke To: Alex McGrath , 40931@debbugs.gnu.org Subject: Re: [bug#40931] [PATCH v2] gnu: add j4-dmenu-desktop In-Reply-To: <20200429075231.6699-1-amk@amk.ie> References: <20200428103705.22597-1-amk@amk.ie> <20200429075231.6699-1-amk@amk.ie> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 16:18:17 +0200 Message-ID: <87sggi2zfa.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40931 Cc: Alex McGrath X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Alex McGrath writes: > * gnu/packages/xdisorg.scm (j4-dmenu-desktop): New variable. Thanks! Unfortunately the patch no longer applies, can you rebase it on the current master branch? [...] > +(define-public j4-dmenu-desktop > + (package > + (name "j4-dmenu-desktop") > + (version "2.17") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/enkore/j4-dmenu-desktop.git") > + (commit (string-append "r" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0v23fimkn83dcm5p53y2ymhklff3kwppxhf75sm8xmswrzkixpgc")))) > + (build-system cmake-build-system) > + (arguments > + `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release" "-DWITH_GIT_CACHE=off" "-DWITH_TESTS=off") Note that cmake-build-system exposes #:build-type, so you don't have to pass "-DCMAKE_BUILD_TYPE". By default it uses RelWithDebugInfo which is better because it adds debug information. There are cases where we want "Release" instead (size or performance concerns), but it probably is fine for this package? > + #:tests? #f)) ;; tests fetch an external git repo Is it possible to provide this repo as a native-input? See e.g. 'ghc'. Don't stress it if it's not possible, though. > + (synopsis "A fast desktop menu") Just "Fast desktop menu" ('./pre-inst-env guix lint j4-dmenu-desktop' should warn about this). > + (description "j4-dmenu-desktop is a replacement for i3-dmenu-desktop. It's purpose is to find desktop files and offer you a menu to start an application using dmenu.") Use two spaces between sentences, and try to wrap lines at ~78 characters. 'guix lint' will warn about this, too. :-) Can you send an updated patch? Thanks in advance! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tgSkACgkQoqBt8qM6 VPpBgggAp7f7NzWe1/tIFRiLeFIVJ+VwCcRrLmG0SznWxM9JeoZhou7XmrN6kyC4 5A8vIgPMDugHH2tuBUW+qLkhC8XCUpE0B519LYCg3t7cZpFWvN7daA5Kngt/7+2+ l8eg7H1ILi9ssqpgk/v9xEUpu4zBVhXg7g81stBnN/rNMB97f9SVeYn/uszPt8Bx cCHUQ/qRKIeow/kjB+AcshyXA0n8cEGh+bsamWxujjyem6QhdVuoMNB1P4oyGYlM +WwEsGh+bScJF+q8MoV+DfmDEU4L+NBsXRi1qRlvqFbuRtL6hDqXS/g3I/joGAPG YAvDQ3r1YN42qXsswUenPORkvwlnpQ== =MOIQ -----END PGP SIGNATURE----- --=-=-=--