From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 26 14:16:36 2020 Received: (at submit) by debbugs.gnu.org; 26 Apr 2020 18:16:36 +0000 Received: from localhost ([127.0.0.1]:34864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSlpU-0001Jc-A2 for submit@debbugs.gnu.org; Sun, 26 Apr 2020 14:16:36 -0400 Received: from lists.gnu.org ([209.51.188.17]:34971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSlpS-0001JT-IZ for submit@debbugs.gnu.org; Sun, 26 Apr 2020 14:16:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35504) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSlpS-0002pw-2P for guix-patches@gnu.org; Sun, 26 Apr 2020 14:16:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, FROM_EXCESS_BASE64, SPF_HELO_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jSlpO-0007df-Bp for guix-patches@gnu.org; Sun, 26 Apr 2020 14:16:33 -0400 Received: from pat.zlotemysli.pl ([37.59.186.212]:46202) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jSlpN-0007dD-N6 for guix-patches@gnu.org; Sun, 26 Apr 2020 14:16:30 -0400 Received: (qmail 15627 invoked by uid 1009); 26 Apr 2020 20:16:26 +0200 Received: from 188.123.215.55 (kuba@kadziolka.net@188.123.215.55) by pat (envelope-from , uid 1002) with qmail-scanner-2.08st (clamdscan: 0.98.6/25793. spamassassin: 3.4.0. perlscan: 2.08st. Clear:RC:1(188.123.215.55):. Processed in 0.027509 secs); 26 Apr 2020 18:16:26 -0000 Received: from unknown (HELO gravity) (kuba@kadziolka.net@188.123.215.55) by pat.zlotemysli.pl with SMTP; 26 Apr 2020 20:16:26 +0200 Date: Sun, 26 Apr 2020 20:16:25 +0200 From: Jakub =?utf-8?B?S8SFZHppb8WCa2E=?= To: Kozo Subject: Re: [PATCH] yarnpkg Message-ID: <20200426181625.tagnhjfz3n7do2cb@gravity> References: <1ba1944d95080f01f02a11c2484e7cb9fa75f538.camel@runbox.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q3nwnwpdmk74sxwk" Content-Disposition: inline In-Reply-To: <1ba1944d95080f01f02a11c2484e7cb9fa75f538.camel@runbox.com> Received-SPF: none client-ip=37.59.186.212; envelope-from=kuba@kadziolka.net; helo=pat.zlotemysli.pl X-detected-operating-system: by eggs.gnu.org: First seen = 2020/04/26 11:59:02 X-ACL-Warn: Detected OS = Linux 3.1-3.10 X-Received-From: 37.59.186.212 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --q3nwnwpdmk74sxwk Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Apr 25, 2020 at 08:15:56PM -0600, Kozo wrote: > Subject: [PATCH] yarnpkg >=20 > --- > yarn.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 47 insertions(+) > create mode 100644 yarn.scm Please write commit logs in the ChangeLog format [0]. You can check the commit history for examples. > (define-module (yarn) Please put the file in gnu/packages/. Also, add it to the list in gnu/local.mk. > #:use-module (guix packages) > #:use-module (guix download) > #:use-module (guix build-system trivial) > #:use-module (guix licenses) > #:use-module (gnu packages node) > #:use-module (ice-9 pretty-print)) I can't see where (ice-9 pretty-print) is being used. > (define yarn-version "1.22.4") What is the purpose of this single-use variable? > (define-public yarn > (package > (name "yarn") > (version yarn-version) > (source (origin > (method url-fetch/tarbomb) The file has only a single directory, so why use /tarbomb? > (uri (string-append "https://github.com/yarnpkg/yarn/releases/downloa= d/v" > version "/yarn-v" version ".tar.gz")) When looking through this download, it seems that the lib/cli.js file is a preprocessed mess. Ideally, we would build the package from source. > (sha256 > (base32 > "0n7vhwjz3lyjnavcaw08cqa8gfampqsy5mm3f555cbqb26m1clxw")))) > (build-system trivial-build-system) > (outputs '("out")) > (inputs `(("node" ,node))) > (arguments > `(#:modules ((guix build utils)) > #:builder (begin > (use-modules (guix build utils)) > (let* ((out (assoc-ref %outputs "out")) > (bin (string-append out "/bin")) > (lib (string-append out "/lib")) The indentation is quite confusing here, I'd suggest running =2E/etc/format-code.el on your file. > (synopsis "Dependency management tool for JavaScript") > (description "Fast, reliable, and secure dependency management tool > for JavaScript. Acts as a drop-in replacement for NodeJS's npm.") I think there are a lot of buzzwords in this description: "fast, reliable and secure" is not an objective property. Is there something more neutral that could be said about the package? Thanks, Jakub K=C4=85dzio=C5=82ka [0]: https://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-L= ogs --q3nwnwpdmk74sxwk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE5Xa/ss9usT31cTO54xWnWEYTFWQFAl6lz/UACgkQ4xWnWEYT FWSYcQ/5AVO/ZT5wVNER0Um86OHo3J1GGrwJxmE87Zhpl+iiSWK4uwaTiXjamVq9 De4oa4b2KVy0GFH35dW5DMoVyBFaxSOzoPXeVB0QTUgZCPwfS2YerPsp2mWE25yo i4PLojbnjQmxLTICLDfCCOLlrRuULQ+0OtlHtFxWlZa2WhTF20RW6kaFVjFzIH84 X95hKEx2LGwz9LW8cbJlhPg6LIytIOBVqIFS+lBJwrFnDux2KGUfeae/PbowLTMA XAxRagg1onyjnABY/Kf09HvfNYtdJ+3rafU33xFLWa/wbg/8THN5HDX0zCbXDjt5 Wr8h641NNzP5pUMUvmEFxx7cxRF65pMMg+GPIHG6pdrfX0RaKJIVYv36QpdDKxq0 ciSTw3nEvAzfUbFaPcuptaO/ldK48CZAa9g1EwiZXwpKmg0+gjUNkNHOAws+oyMl FGVNR/rnOKLz3xDroQdbQe1RmEDyH3CM0OrLKYAkL2ucQE+uXOPTmFc5MuCJ2fl0 U/YB9KyHKoA8fKXUSetXhL5IPF/OYo4134LYl7dmmNqi4F8reJafpYDN2ffIdpxs llIhmUtULBlpYb2sx99W3I51NxvScTM3uD8S8xVODROXk4XGa+YvudTqc17FryxD ipyUXEY728M+CVC/JPKGvDtZkk6xmwKVR/YoByUSRs6FyYYPeJo= =gVN/ -----END PGP SIGNATURE----- --q3nwnwpdmk74sxwk--