From debbugs-submit-bounces@debbugs.gnu.org Sat May 02 10:24:21 2020 Received: (at 40791) by debbugs.gnu.org; 2 May 2020 14:24:21 +0000 Received: from localhost ([127.0.0.1]:53611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUt3n-0000Lm-AH for submit@debbugs.gnu.org; Sat, 02 May 2020 10:24:21 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUt3l-0000Ki-Ix for 40791@debbugs.gnu.org; Sat, 02 May 2020 10:24:05 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id CE00D4F1; Sat, 2 May 2020 10:23:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 02 May 2020 10:24:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= from:to:subject:in-reply-to:references:date:message-id :mime-version:content-type; s=fm2; bh=GuO+MIW6t7NWutJIiemhhXcDKC 975A1NBE3Lp8u/d7g=; b=i+vyJQ2JDMiAtf7iqcLg/G0Z/2jYUDxYqxMnjmJ2Ao WK+88HJyGCOkbwU7uFtfjfF7h5fQBisI0wmyZDkxrdZi932s9+stSnMnF7AqPmMZ VaLJwwBk89ooEmljnLDTngDeDu5YIzGL0CATHICksufHiIuOZJOYmpE9zPNLSpWP oyDEWL/L1u33FKQhW0W5SU6WUs0zlaFMdO6Hs7zyZnSZRQ/RnCdlX9zaNtL6vj1f gEGm0jgwZeIXq2Hg0qrzb2KdkX/w1QbodBlZyQCmeJQch/IKDV883/kpO7qhwZG7 18RewViU93M2myEk5accrOaszD8zgggasml5ShmLSANQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GuO+MI W6t7NWutJIiemhhXcDKC975A1NBE3Lp8u/d7g=; b=iqutADswim8HzE6/ub1Zhl hEJpufAovgqGZwA/gb7XL9aKYoHxd4AhWK3COTBInhdmKKoIUVZrsovfSIpjamwZ zILMMI3HnC08kzgyPf0vkQnrHyupJlVnt9v0MJE1Pl8wGL6RXdGHcPdCPgYpq634 tKfRvBfYcR2MiTOBlsk/ldQ3VSXFoDEd428VH+V2KinbDuZ1yaD8EffgxfkkvAf9 obicA4Y+Zd0ShFc/z49cK5NS+X/nZ5hLxXVj89thSGF/GbR3BX0treDtB5IACiJO SV2u8p8kNfMuV+ecQfg8ovWaVcvrZDTawj2l7YoyZjJ6zy/oVpZy28+tm6egHGFA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrieelgdejfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffgffkfggtgesghdtreertdertdenucfhrhhomhepofgrrhhiuhhs uceurghkkhgvuceomhgsrghkkhgvsehfrghsthhmrghilhdrtghomheqnecuggftrfgrth htvghrnheptddvgfegveegiedvffeujeeitdetvdektddugffgtdegfeeitdeikeffudfg ueffnecukfhppeekgedrvddtvddrieekrdejheenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehmsggrkhhkvgesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: from localhost (ti0006q161-2604.bb.online.no [84.202.68.75]) by mail.messagingengine.com (Postfix) with ESMTPA id C58243280064; Sat, 2 May 2020 10:23:58 -0400 (EDT) From: Marius Bakke To: Tom , Tom via Guix-patches , 40791@debbugs.gnu.org Subject: Re: [bug#40791] todays patch In-Reply-To: <1819894.BzRgMNaeKi@peach> References: <2419210.ElGaqSPkdT@peach> <1819894.BzRgMNaeKi@peach> User-Agent: Notmuch/0.29.3 (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Sat, 02 May 2020 16:23:57 +0200 Message-ID: <87mu6q2z5u.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40791 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Tom via Guix-patches via writes: > This incorporates all suggestions. > > As each individual missing item in the qtwebengine requires a full rebuil= d to=20 > get one line of error, I've done enough for today. See the amount of line= s=20 > added ;) Thanks! I plan to do a proper review on a couple of days, but have one suggestion for qtwebengine: moving the 'snippet' code into a phase allows for faster iterations. Still not trivial, but better than repacking for every change! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl6tgn0ACgkQoqBt8qM6 VPrrbQf/VK5kFbbx2dLbLLNjdXvyN+o2ePdHBE8aeSA0N6Ypunp+fIUUiN0vFuD2 DwIICnoiO1WXlr0zTgr3aUZ06JavhTdagK8PokdDdwx0iyC1aaCaDJ5FWauK24dx 6pDTwtkpYPXx80ZgQWpKIoGkyOph3r2Mzrc263qMX43lkPraBN4z3QDL1UHPYvPo jgge1C+n0zNQDIdeHjSqt0OtHjCrRdI5X5eRQnIyLCRjSzMZABO+8zSN+p9lAc7A uaFTzN9GL7v6VgDOxt5Q8V83h2/dQyN90ubsyxDxRCeZo4LriSzw3GO07V5oOlrk zXH9RumE0RQ6D+b0w5zxL0pnSZkMuw== =gH1K -----END PGP SIGNATURE----- --=-=-=--