From debbugs-submit-bounces@debbugs.gnu.org Fri May 01 13:05:28 2020 Received: (at 40782) by debbugs.gnu.org; 1 May 2020 17:05:28 +0000 Received: from localhost ([127.0.0.1]:50550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZ6O-00078o-3f for submit@debbugs.gnu.org; Fri, 01 May 2020 13:05:28 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:41167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jUZ6M-00078a-9t for 40782@debbugs.gnu.org; Fri, 01 May 2020 13:05:27 -0400 Received: from webmail.gandi.net (webmail18.sd4.0x35.net [10.200.201.18]) (Authenticated sender: brice@waegenei.re) by relay2-d.mail.gandi.net (Postfix) with ESMTPA id 5E5A340009; Fri, 1 May 2020 17:05:19 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 01 May 2020 17:05:19 +0000 From: Brice Waegeneire To: tomz@freedommail.ch Subject: Re: patch#40782 new package; hexer Message-ID: <5176e4dd335766c41e5cb50a3813a1f2@waegenei.re> X-Sender: brice@waegenei.re User-Agent: Roundcube Webmail/1.3.8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 40782 Cc: 40782@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello Tom, Thank you for the patch! There a few minor thing to adjust from your patch: 1. Add your copyright at the top of the file. 2. End your git title and message lines with a colon. 2. Use the latest version of the package, 1.0.6. 3. Keep the description line under 80 character. 4. Add a comment about why the tests are disabled, in our case there is no test suite. Cheers, - Brice