From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 19 05:12:37 2020 Received: (at submit) by debbugs.gnu.org; 19 Apr 2020 09:12:37 +0000 Received: from localhost ([127.0.0.1]:44033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQ60D-00064P-Gb for submit@debbugs.gnu.org; Sun, 19 Apr 2020 05:12:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:59126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jQ60B-00064H-6g for submit@debbugs.gnu.org; Sun, 19 Apr 2020 05:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47938) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQ60A-0000jf-Is for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jQ609-0004ag-Tg for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:34 -0400 Received: from devianza.investici.org ([198.167.222.108]:59153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jQ609-00042n-42 for bug-guix@gnu.org; Sun, 19 Apr 2020 05:12:33 -0400 Received: from 1.mail-backend.investici.org (unknown [10.0.0.11]) by devianza.investici.org (Postfix) with ESMTP id A065AE0541 for ; Sun, 19 Apr 2020 09:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1587287540; bh=VHrrVTvaAyhltyzhudKebSH7mVcBEtyUJQqCL4mhtLk=; h=Date:From:To:Subject:From; b=Ryfxv+25g/r+5JCJBZ/ytsnUUOQB0uAYubFOtSQ0ceVoNigW+RHzP894e9q2lqlAL 4v1Wddwcpqbtium2dsWJfSQccGoLy8eqN0OWOauU77fg72tVeQcuXMhEYvl2Z1t80C h8z80bnEy+pYS78aNqjumzSiUTuySKBIgjD8LGXU= Received: from 1.webmail.investici.org (localhost [127.0.0.1]) (Authenticated sender: goodoldpaul@autistici.org) by 1.mail-backend.investici.org (Postfix) with ESMTPA id 82BF8C1FA7 for ; Sun, 19 Apr 2020 09:12:20 +0000 (UTC) MIME-Version: 1.0 Date: Sun, 19 Apr 2020 09:12:20 +0000 From: goodoldpaul@autistici.org To: bug-guix@gnu.org Subject: node-build-system should not install tests User-Agent: Roundcube Webmail Message-ID: X-Sender: goodoldpaul@autistici.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=198.167.222.108; envelope-from=goodoldpaul@autistici.org; helo=devianza.investici.org X-detected-operating-system: by eggs.gnu.org: Linux 2.2.x-3.x [generic] X-Received-From: 198.167.222.108 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) As discussed here [0], node-build-system right now installs all the contents of a package's root node_modules directory, including i.e. tests. We should investigate how exactly npm decides what to install and try to replicate that inside node-build-system. It seems likely that it uses the "files" array from the package.json file (see [1-2]). [0]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36599 [1]: https://github.com/colorjs/color-name/blob/master/package.json#L6 [2]: https://github.com/npm/node-semver/blob/master/package.json#L21