On Fri, Apr 17, 2020 at 11:16:44PM +0200, Ludovic Courtès wrote: > Hi Jakub, > > Jakub Kądziołka skribis: > > > * guix/git-download.scm (git-version): Add a check for commit ID length. > > --- > > If you're curious for the motivation, see [1]. This took a while to > > debug, so I'm hoping to ease this for the next person who inevitably > > stumbles upon this. Is a change like this okay? > > Yes, I think so. The ‘error’ procedure is not great, we would rather > use ‘raise’ with a ‘&message’ condition (which additionally allows for > i18n) but it’s no big deal here. I considered using raise instead, but I couldn't get it to work properly. I was getting a "Wrong type (expecting exact integer)" error instead: (raise (condition (&message (message "git-version: commit ID unexpectedly short")))) Do you know why that might be? Regards, Jakub Kądziołka